2019-03-19 14:41:45

by Yue Haibing

Subject: [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static

From: YueHaibing <[email protected]>

Fix sparse warning:

net/netfilter/nft_redir.c:85:5:
warning: symbol 'nft_redir_dump' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
net/netfilter/nft_redir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nft_redir.c b/net/netfilter/nft_redir.c
index a340cd8..02f4b4a 100644
--- a/net/netfilter/nft_redir.c
+++ b/net/netfilter/nft_redir.c
@@ -82,7 +82,7 @@ static int nft_redir_init(const struct nft_ctx *ctx,
return nf_ct_netns_get(ctx->net, ctx->family);
}

-int nft_redir_dump(struct sk_buff *skb, const struct nft_expr *expr)
+static int nft_redir_dump(struct sk_buff *skb, const struct nft_expr *expr)
{
const struct nft_redir *priv = nft_expr_priv(expr);

--
2.7.4

2019-04-08 21:32:48

by Pablo Neira Ayuso

Subject: Re: [PATCH net-next] netfilter: nft_redir: Make nft_redir_dump static

On Tue, Mar 19, 2019 at 10:40:21PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> net/netfilter/nft_redir.c:85:5:
> warning: symbol 'nft_redir_dump' was not declared. Should it be static?

Applied, thanks.