2019-04-02 19:51:29

by Adam Ford

Subject: [PATCH V2] ARM: dts: imx6q-logicpd: Enable Analog audio capture

The original submission had functional audio out and was based
on reviewing other boards using the same wm8962 codec. However,
the Logic PD board uses an analog microphone which was being
disabled for a digital mic. This patch corrects that and
explicitly sets the gpio-cfg pins all to 0x0000 which allows the
analog microphone to capture audio.

Signed-off-by: Adam Ford <[email protected]>
---
V2: Remove 'fixes' note reference Shawn's request.

diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
index e31b6923cb72..db6b5b900826 100644
--- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
+++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
@@ -248,9 +248,9 @@
gpio-cfg = <
0x0000 /* 0:Default */
0x0000 /* 1:Default */
- 0x0013 /* 2:FN_DMICCLK */
+ 0x0000 /* 2:FN_DMICCLK */
0x0000 /* 3:Default */
- 0x8014 /* 4:FN_DMICCDAT */
+ 0x0000 /* 4:FN_DMICCDAT */
0x0000 /* 5:Default */
>;
};
--
2.17.1

2019-04-02 19:51:32

by Adam Ford

Subject: [PATCH V2] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

The LCD power sequencer is very finicky. The backlight cannot
be driven until after the sequencer is done. Until now, the
regulators were marked with 'regulator-always-on' to make sure
it came up before the backlight. This patch allows the LCD
regulators to power down and prevent the backlight from being
used again until the sequencer is ready. This reduces
standby power consumption by ~100mW.

Signed-off-by: Adam Ford <[email protected]>
---
V2: Remove 'fixes' reference per Shawn's request

diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index 45eb0b7f75f8..d96ae54be338 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -21,6 +21,8 @@

panel-lvds0 {
compatible = "okaya,rs800480t-7x0gp";
+ power-supply = <&reg_lcd_reset>;
+ backlight = <&backlight>;

port {
panel_in_lvds0: endpoint {
@@ -38,7 +40,6 @@
regulator-max-microvolt = <3300000>;
gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>;
enable-active-high;
- regulator-always-on;
vin-supply = <&reg_3v3>;
startup-delay-us = <500000>;
};
@@ -52,7 +53,6 @@
regulator-max-microvolt = <3300000>;
gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
enable-active-high;
- regulator-always-on;
vin-supply = <&reg_lcd>;
};
};
--
2.17.1

2019-04-11 05:47:31

by Shawn Guo

Subject: Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable Analog audio capture

On Tue, Apr 02, 2019 at 02:25:45PM -0500, Adam Ford wrote:
> The original submission had functional audio out and was based
> on reviewing other boards using the same wm8962 codec. However,
> the Logic PD board uses an analog microphone which was being
> disabled for a digital mic. This patch corrects that and
> explicitly sets the gpio-cfg pins all to 0x0000 which allows the
> analog microphone to capture audio.
>
> Signed-off-by: Adam Ford <[email protected]>

Applied, thanks.

2019-04-11 05:49:48

by Shawn Guo

Subject: Re: [PATCH V2] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

On Tue, Apr 02, 2019 at 02:25:46PM -0500, Adam Ford wrote:
> The LCD power sequencer is very finicky. The backlight cannot
> be driven until after the sequencer is done. Until now, the
> regulators were marked with 'regulator-always-on' to make sure
> it came up before the backlight. This patch allows the LCD
> regulators to power down and prevent the backlight from being
> used again until the sequencer is ready. This reduces
> standby power consumption by ~100mW.
>
> Signed-off-by: Adam Ford <[email protected]>

Applied, thanks.