Add Pincfgs to enable the i.MX6's OTG feature for UDOO
Signed-off-by: Markus Kueffner <[email protected]>
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 776bfc7..42954ee 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -221,6 +221,14 @@
>;
};
+ pinctrl_usbotg: usbotg {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+ MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+ >;
+ };
+
pinctrl_ac97_running: ac97running {
fsl,pins = <
MX6QDL_PAD_DI0_PIN2__AUD6_TXD 0x1b0b0
@@ -294,6 +302,14 @@
status = "okay";
};
+&usbotg {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ fsl,power-line-polarity-active-high;
+ fsl,over-current-polarity-active-low;
+ status = "okay";
+};
+
&audmux {
status = "okay";
};
--
2.1.4
On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <[email protected]>
> ---
> arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 776bfc7..42954ee 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -221,6 +221,14 @@
> >;
> };
>
> + pinctrl_usbotg: usbotg {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> + MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
> + >;
> + };
> +
I know ac97 is out of order, but I still would like to keep pinctrl
nodes sort alphabetically. That said, pinctrl_usbotg should go after
pinctrl_usbh.
> pinctrl_ac97_running: ac97running {
> fsl,pins = <
> MX6QDL_PAD_DI0_PIN2__AUD6_TXD 0x1b0b0
> @@ -294,6 +302,14 @@
> status = "okay";
> };
>
> +&usbotg {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbotg>;
> + fsl,power-line-polarity-active-high;
> + fsl,over-current-polarity-active-low;
Are these two properties supported by upstream bindings and driver?
Shawn
> + status = "okay";
> +};
> +
> &audmux {
> status = "okay";
> };
> --
> 2.1.4
>
Add Pincfgs to enable the i.MX6's OTG feature for UDOO
Signed-off-by: Markus Kueffner <[email protected]>
---
Changes in v2:
- put pinctrl_usbotg node after pinctrl_usbh as suggested
- remove unsupported properties from &usbotg
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 776bfc7..828dd20 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -210,6 +210,14 @@
>;
};
+ pinctrl_usbotg: usbotg {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+ MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+ >;
+ };
+
pinctrl_usdhc3: usdhc3grp {
fsl,pins = <
MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
@@ -287,6 +295,12 @@
status = "okay";
};
+&usbotg {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ status = "okay";
+};
+
&usdhc3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc3>;
--
2.1.4
On Sat, Apr 13, 2019 at 10:20 AM Markus Kueffner
<[email protected]> wrote:
>
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <[email protected]>
Applied, thanks.
On Mon, Apr 15, 2019 at 05:11:51PM +0800, Shawn Guo wrote:
> On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> > Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> >
> > Signed-off-by: Markus Kueffner <[email protected]>
>
> Applied, thanks.
Hello,
I was wondering when this might get merged into a release.
Is there anything else I need to fix?
Best Regards,
Markus
On Mon, Sep 16, 2019 at 01:06:04PM +0000, Markus Kueffner wrote:
> On Mon, Apr 15, 2019 at 05:11:51PM +0800, Shawn Guo wrote:
> > On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> > > Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> > >
> > > Signed-off-by: Markus Kueffner <[email protected]>
> >
> > Applied, thanks.
>
> Hello,
>
> I was wondering when this might get merged into a release.
> Is there anything else I need to fix?
I'm sorry, Markus. There was something wrong on my side, and the patch
did not really get applied for 5.4. I just fixed it for the next
release. Sorry about that!
Shawn