2019-04-12 23:35:41

by Dexuan Cui

Subject: [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()

With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
warning in preempt_count_sub().

Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
Cc: [email protected]
Cc: Stephen Hemminger <[email protected]>
Signed-off-by: Dexuan Cui <[email protected]>
---
drivers/hv/hv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 632d25674e7f..45653029ee18 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -408,7 +408,6 @@ int hv_synic_cleanup(unsigned int cpu)

clockevents_unbind_device(hv_cpu->clk_evt, cpu);
hv_ce_shutdown(hv_cpu->clk_evt);
- put_cpu_ptr(hv_cpu);
}

hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
--
2.19.1

2019-04-13 02:20:49

by Michael Kelley (LINUX)

Subject: RE: [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()

From: Dexuan Cui <[email protected]> Sent: Friday, April 12, 2019 4:35 PM
>
> With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
> warning in preempt_count_sub().
>
> Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
> Cc: [email protected]
> Cc: Stephen Hemminger <[email protected]>
> Signed-off-by: Dexuan Cui <[email protected]>

Reviewed-by: Michael Kelley <[email protected]>

2019-04-13 13:39:37

by Sasha Levin

Subject: Re: [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()

On Sat, Apr 13, 2019 at 02:19:52AM +0000, Michael Kelley wrote:
>From: Dexuan Cui <[email protected]> Sent: Friday, April 12, 2019 4:35 PM
>>
>> With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
>> warning in preempt_count_sub().
>>
>> Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
>> Cc: [email protected]
>> Cc: Stephen Hemminger <[email protected]>
>> Signed-off-by: Dexuan Cui <[email protected]>
>
>Reviewed-by: Michael Kelley <[email protected]>

Queued for hyperv-fixes, thanks all.

--
Thanks,
Sasha