2019-04-14 18:38:44

by Andrey Smirnov

Subject: [PATCH 1/2] ARM: dts: vf610-zii-dev: Mark i2c0 SCL as GPIO_OPEN_DRAIN

Mark i2c0 SCL as GPIO_OPEN_DRAIN to fix the following warning:

gpio-36 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: [email protected]
---
arch/arm/boot/dts/vf610-zii-dev.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
index 19eb4a849efb..2d1e9b3203fa 100644
--- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
+++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
@@ -138,7 +138,7 @@
pinctrl-names = "default", "gpio";
pinctrl-0 = <&pinctrl_i2c0>;
pinctrl-1 = <&pinctrl_i2c0_gpio>;
- scl-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
+ scl-gpios = <&gpio1 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
sda-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
status = "okay";

--
2.20.1

2019-04-14 18:37:29

by Andrey Smirnov

Subject: [PATCH 2/2] ARM: dts: vf610-zii-dev-rev-b: Specify CS as GPIO_ACTIVE_LOW in spi0

Specify CS as GPIO_ACTIVE_LOW in spi0 to fix the following warning:

m25p128@0 enforce active low on chipselect handle

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: [email protected]
---
arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
index bd79e00bf615..87b4d2cbe106 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
@@ -334,7 +334,7 @@
gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
gpio-mosi = <&gpio1 11 GPIO_ACTIVE_HIGH>;
gpio-miso = <&gpio1 10 GPIO_ACTIVE_HIGH>;
- cs-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH
+ cs-gpios = <&gpio1 9 GPIO_ACTIVE_LOW
&gpio1 8 GPIO_ACTIVE_HIGH>;
num-chipselects = <2>;

--
2.20.1

2019-04-22 01:59:02

by Shawn Guo

Subject: Re: [PATCH 1/2] ARM: dts: vf610-zii-dev: Mark i2c0 SCL as GPIO_OPEN_DRAIN

On Sun, Apr 14, 2019 at 11:35:57AM -0700, Andrey Smirnov wrote:
> Mark i2c0 SCL as GPIO_OPEN_DRAIN to fix the following warning:
>
> gpio-36 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
> Signed-off-by: Andrey Smirnov <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Chris Healy <[email protected]>
> Cc: Andrew Lunn <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: [email protected]

Applied both, thanks.