2019-04-16 10:27:53

by Wolfram Sang

Subject: [PATCH v2 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout

The core will print out details now.

Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/watchdog/ebc-c384_wdt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c
index 4c4c8ce78021..c176f59fea28 100644
--- a/drivers/watchdog/ebc-c384_wdt.c
+++ b/drivers/watchdog/ebc-c384_wdt.c
@@ -117,10 +117,7 @@ static int ebc_c384_wdt_probe(struct device *dev, unsigned int id)
wdd->max_timeout = WATCHDOG_MAX_TIMEOUT;

watchdog_set_nowayout(wdd, nowayout);
-
- if (watchdog_init_timeout(wdd, timeout, dev))
- dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
- timeout, WATCHDOG_TIMEOUT);
+ watchdog_init_timeout(wdd, timeout, dev);

return devm_watchdog_register_device(dev, wdd);
}
--
2.11.0

2019-04-16 10:28:42

by William Breathitt Gray

Subject: Re: [PATCH v2 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout

On Tue, Apr 16, 2019 at 12:25:04PM +0200, Wolfram Sang wrote:
> The core will print out details now.
>
> Reviewed-by: Guenter Roeck <[email protected]>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> drivers/watchdog/ebc-c384_wdt.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c
> index 4c4c8ce78021..c176f59fea28 100644
> --- a/drivers/watchdog/ebc-c384_wdt.c
> +++ b/drivers/watchdog/ebc-c384_wdt.c
> @@ -117,10 +117,7 @@ static int ebc_c384_wdt_probe(struct device *dev, unsigned int id)
> wdd->max_timeout = WATCHDOG_MAX_TIMEOUT;
>
> watchdog_set_nowayout(wdd, nowayout);
> -
> - if (watchdog_init_timeout(wdd, timeout, dev))
> - dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
> - timeout, WATCHDOG_TIMEOUT);
> + watchdog_init_timeout(wdd, timeout, dev);
>
> return devm_watchdog_register_device(dev, wdd);
> }
> --
> 2.11.0

Acked-by: William Breathitt Gray <[email protected]>