2019-04-17 08:45:12

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: stm32-pwr: Fix error checking for of_iomap

of_iomap returns NULL on error.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/stm32-pwr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index 222d593d76a2..dd5c2b383e5b 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -140,9 +140,9 @@ static int stm32_pwr_regulator_probe(struct platform_device *pdev)
int i, ret = 0;

base = of_iomap(np, 0);
- if (IS_ERR(base)) {
+ if (!base) {
dev_err(&pdev->dev, "Unable to map IO memory\n");
- return PTR_ERR(base);
+ return -ENODEV;
}

config.dev = &pdev->dev;
--
2.17.1


2019-04-17 16:38:03

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: stm32-pwr: Fix error checking for of_iomap

On Wed, Apr 17, 2019 at 04:43:35PM +0800, Axel Lin wrote:
> of_iomap returns NULL on error.

Someone already sent a patch for this.


Attachments:
(No filename) (136.00 B)
signature.asc (499.00 B)
Download all attachments