2019-04-08 07:44:05

by Lionel Debieve

Subject: [PATCH 1/1] crypto: stm32/hash - Fix self test issue during export

Change the wait condition to check if the hash is busy.
Context can be saved as soon as hash has finishing processing
data. Remove unused lock in the device structure.

Signed-off-by: Lionel Debieve <[email protected]>
---
drivers/crypto/stm32/stm32-hash.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index 4a6cc8a..bfc49e6 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -181,8 +181,6 @@ struct stm32_hash_dev {
u32 dma_mode;
u32 dma_maxburst;

- spinlock_t lock; /* lock to protect queue */
-
struct ahash_request *req;
struct crypto_engine *engine;

@@ -977,7 +975,7 @@ static int stm32_hash_export(struct ahash_request *req, void *out)

pm_runtime_get_sync(hdev->dev);

- while (!(stm32_hash_read(hdev, HASH_SR) & HASH_SR_DATA_INPUT_READY))
+ while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY))
cpu_relax();

rctx->hw_context = kmalloc_array(3 + HASH_CSR_REGISTER_NUMBER,
--
2.7.4

2019-04-18 15:17:49

by Herbert Xu

Subject: Re: [PATCH 1/1] crypto: stm32/hash - Fix self test issue during export

On Mon, Apr 08, 2019 at 09:41:58AM +0200, Lionel Debieve wrote:
> Change the wait condition to check if the hash is busy.
> Context can be saved as soon as hash has finishing processing
> data. Remove unused lock in the device structure.
>
> Signed-off-by: Lionel Debieve <[email protected]>
> ---
> drivers/crypto/stm32/stm32-hash.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt