2019-04-19 22:46:45

by Po-Hsu Lin

Subject: [PATCH] selftests/net: correct the return value for run_afpackettests

The run_afpackettests will be marked as passed regardless the return
value of those sub-tests in the script:
--------------------
running psock_tpacket test
--------------------
[FAIL]
selftests: run_afpackettests [PASS]

Fix this by changing the return value for each tests.

Signed-off-by: Po-Hsu Lin <[email protected]>
---
tools/testing/selftests/net/run_afpackettests | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/net/run_afpackettests b/tools/testing/selftests/net/run_afpackettests
index 2dc95fd..ea5938e 100755
--- a/tools/testing/selftests/net/run_afpackettests
+++ b/tools/testing/selftests/net/run_afpackettests
@@ -6,12 +6,14 @@ if [ $(id -u) != 0 ]; then
exit 0
fi

+ret=0
echo "--------------------"
echo "running psock_fanout test"
echo "--------------------"
./in_netns.sh ./psock_fanout
if [ $? -ne 0 ]; then
echo "[FAIL]"
+ ret=1
else
echo "[PASS]"
fi
@@ -22,6 +24,7 @@ echo "--------------------"
./in_netns.sh ./psock_tpacket
if [ $? -ne 0 ]; then
echo "[FAIL]"
+ ret=1
else
echo "[PASS]"
fi
@@ -32,6 +35,8 @@ echo "--------------------"
./in_netns.sh ./txring_overwrite
if [ $? -ne 0 ]; then
echo "[FAIL]"
+ ret=1
else
echo "[PASS]"
fi
+exit $ret
--
2.7.4

2019-04-19 21:41:14

by David Miller

Subject: Re: [PATCH] selftests/net: correct the return value for run_afpackettests

From: Po-Hsu Lin <[email protected]>
Date: Fri, 19 Apr 2019 19:01:13 +0800

> The run_afpackettests will be marked as passed regardless the return
> value of those sub-tests in the script:
> --------------------
> running psock_tpacket test
> --------------------
> [FAIL]
> selftests: run_afpackettests [PASS]
>
> Fix this by changing the return value for each tests.
>
> Signed-off-by: Po-Hsu Lin <[email protected]>

Applied, thank you.

2019-04-21 03:30:29

by David Miller

Subject: Re: [PATCH] selftests/net: correct the return value for run_afpackettests

From: Po-Hsu Lin <[email protected]>
Date: Fri, 19 Apr 2019 19:01:13 +0800

> The run_afpackettests will be marked as passed regardless the return
> value of those sub-tests in the script:
> --------------------
> running psock_tpacket test
> --------------------
> [FAIL]
> selftests: run_afpackettests [PASS]
>
> Fix this by changing the return value for each tests.
>
> Signed-off-by: Po-Hsu Lin <[email protected]>

Applied, thanks.