2019-04-18 09:51:53

by Mauro Carvalho Chehab

Subject: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c

Those files were moved to lib/math.

Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
Documentation/core-api/kernel-api.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
index 71f5d2fe39b7..a29c99d13331 100644
--- a/Documentation/core-api/kernel-api.rst
+++ b/Documentation/core-api/kernel-api.rst
@@ -147,10 +147,10 @@ Division Functions
.. kernel-doc:: include/linux/math64.h
:internal:

-.. kernel-doc:: lib/div64.c
+.. kernel-doc:: lib/math/div64.c
:functions: div_s64_rem div64_u64_rem div64_u64 div64_s64

-.. kernel-doc:: lib/gcd.c
+.. kernel-doc:: lib/math/gcd.c
:export:

UUID/GUID
--
2.20.1

2019-04-18 22:01:08

by Randy Dunlap

Subject: Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c

On 4/18/19 2:50 AM, Mauro Carvalho Chehab wrote:
> Those files were moved to lib/math.
>
> Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")

Is that commid ID in mainline? I get:
fatal: ambiguous argument '9635bad21596': unknown revision or path not in the working tree.

> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> Documentation/core-api/kernel-api.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index 71f5d2fe39b7..a29c99d13331 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -147,10 +147,10 @@ Division Functions
> .. kernel-doc:: include/linux/math64.h
> :internal:
>
> -.. kernel-doc:: lib/div64.c
> +.. kernel-doc:: lib/math/div64.c
> :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
>
> -.. kernel-doc:: lib/gcd.c
> +.. kernel-doc:: lib/math/gcd.c
> :export:
>
> UUID/GUID
>


--
~Randy

2019-04-18 23:15:02

by Mauro Carvalho Chehab

Subject: Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c

Em Thu, 18 Apr 2019 14:59:41 -0700
Randy Dunlap <[email protected]> escreveu:

> On 4/18/19 2:50 AM, Mauro Carvalho Chehab wrote:
> > Those files were moved to lib/math.
> >
> > Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")
>
> Is that commid ID in mainline? I get:
> fatal: ambiguous argument '9635bad21596': unknown revision or path not in the working tree.

No, it is on Linux-next.

>
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> Acked-by: Randy Dunlap <[email protected]>
>
> Thanks.
>
> > ---
> > Documentation/core-api/kernel-api.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> > index 71f5d2fe39b7..a29c99d13331 100644
> > --- a/Documentation/core-api/kernel-api.rst
> > +++ b/Documentation/core-api/kernel-api.rst
> > @@ -147,10 +147,10 @@ Division Functions
> > .. kernel-doc:: include/linux/math64.h
> > :internal:
> >
> > -.. kernel-doc:: lib/div64.c
> > +.. kernel-doc:: lib/math/div64.c
> > :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
> >
> > -.. kernel-doc:: lib/gcd.c
> > +.. kernel-doc:: lib/math/gcd.c
> > :export:
> >
> > UUID/GUID
> >
>
>



Thanks,
Mauro

2019-04-19 18:57:35

by Jonathan Corbet

Subject: Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c

On Thu, 18 Apr 2019 06:50:18 -0300
Mauro Carvalho Chehab <[email protected]> wrote:

> Those files were moved to lib/math.
>
> Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
> Documentation/core-api/kernel-api.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index 71f5d2fe39b7..a29c99d13331 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -147,10 +147,10 @@ Division Functions
> .. kernel-doc:: include/linux/math64.h
> :internal:
>
> -.. kernel-doc:: lib/div64.c
> +.. kernel-doc:: lib/math/div64.c
> :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
>
> -.. kernel-doc:: lib/gcd.c
> +.. kernel-doc:: lib/math/gcd.c
> :export:

This, of course, creates a build error in docs-next...hopefully that
situation won't last more than a couple of weeks or so. Applied, thanks.

jon

2019-04-19 20:38:39

by Andrew Morton

Subject: Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c

On Fri, 19 Apr 2019 12:55:48 -0600 Jonathan Corbet <[email protected]> wrote:

> > -.. kernel-doc:: lib/div64.c
> > +.. kernel-doc:: lib/math/div64.c
> > :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
> >
> > -.. kernel-doc:: lib/gcd.c
> > +.. kernel-doc:: lib/math/gcd.c
> > :export:
>
> This, of course, creates a build error in docs-next...hopefully that
> situation won't last more than a couple of weeks or so.

I'll fold this into the base patch
lib-move-mathematic-helpers-to-separate-folder.patch so there won't be
such a situation.

> Applied, thanks.

Please unapply ;)