2019-04-19 21:12:45

by Madhumitha Prabakaran

Subject: [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()

Remove unwanted variable and replace the respective return type.

Issue suggested by Coccinelle.

Signed-off-by: Madhumitha Prabakaran <[email protected]>
---
drivers/staging/mt7621-mmc/sd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index b12ed2c988fd..2b327fde7145 100644
--- a/drivers/staging/mt7621-mmc/sd.c
+++ b/drivers/staging/mt7621-mmc/sd.c
@@ -752,7 +752,6 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host)
{
struct mmc_command cmd;
struct mmc_request mrq;
- u32 err;

memset(&cmd, 0, sizeof(struct mmc_command));
cmd.opcode = MMC_APP_CMD;
@@ -763,8 +762,7 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host)
mrq.cmd = &cmd; cmd.mrq = &mrq;
cmd.data = NULL;

- err = msdc_do_command(host, &cmd, 0, CMD_TIMEOUT);
- return err;
+ return msdc_do_command(host, &cmd, 0, CMD_TIMEOUT);
}

static int msdc_tune_cmdrsp(struct msdc_host *host, struct mmc_command *cmd)
--
2.17.1

2019-04-20 21:06:24

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()

On Fri, Apr 19, 2019 at 04:11:30PM -0500, Madhumitha Prabakaran wrote:
> Remove unwanted variable and replace the respective return type.
>
> Issue suggested by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran <[email protected]>
> ---
> drivers/staging/mt7621-mmc/sd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

This file is long deleted. Always make sure you work off of the latest
development tree for the subsystem you are wanting to contribute to. Or
on linux-next at the least.

thanks,

greg k-h