2019-04-20 12:52:53

by J. Neuschäfer

Subject: [PATCH] drm/sched: Fix description of drm_sched_stop

Since commit 222b5f044159 ("drm/sched: Refactor ring mirror list
handling."), drm_sched_hw_job_reset is no longer there, so let's adjust
the doc comment accordingly.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
drivers/gpu/drm/scheduler/sched_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 19fc601c9eeb..a1bec2779e76 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -366,10 +366,9 @@ void drm_sched_increase_karma(struct drm_sched_job *bad)
EXPORT_SYMBOL(drm_sched_increase_karma);

/**
- * drm_sched_hw_job_reset - stop the scheduler if it contains the bad job
+ * drm_sched_stop - stop the scheduler
*
* @sched: scheduler instance
- * @bad: bad scheduler job
*
*/
void drm_sched_stop(struct drm_gpu_scheduler *sched)
--
2.20.1

2019-04-23 14:20:40

by Andrey Grodzovsky

Subject: Re: [PATCH] drm/sched: Fix description of drm_sched_stop

Reviewed-by: Andrey Grodzovsky <[email protected]>

Andrey

On 4/20/19 8:50 AM, Jonathan Neuschäfer wrote:
> Since commit 222b5f044159 ("drm/sched: Refactor ring mirror list
> handling."), drm_sched_hw_job_reset is no longer there, so let's adjust
> the doc comment accordingly.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 19fc601c9eeb..a1bec2779e76 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -366,10 +366,9 @@ void drm_sched_increase_karma(struct drm_sched_job *bad)
> EXPORT_SYMBOL(drm_sched_increase_karma);
>
> /**
> - * drm_sched_hw_job_reset - stop the scheduler if it contains the bad job
> + * drm_sched_stop - stop the scheduler
> *
> * @sched: scheduler instance
> - * @bad: bad scheduler job
> *
> */
> void drm_sched_stop(struct drm_gpu_scheduler *sched)
> --
> 2.20.1
>