2019-04-20 16:44:19

by Huaisheng Ye

Subject: [PATCH] dm-writecache: remove unused member page_offset in writeback_struct

From: Huaisheng Ye <[email protected]>

The structure member page_offset in writeback_struct never has been
used actually. Remove it.

Signed-off-by: Huaisheng Ye <[email protected]>
---
drivers/md/dm-writecache.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index cfbbfbc..ddf1732 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -190,7 +190,6 @@ struct writeback_struct {
struct dm_writecache *wc;
struct wc_entry **wc_list;
unsigned wc_list_n;
- unsigned page_offset;
struct page *page;
struct wc_entry *wc_list_inline[WB_LIST_INLINE];
struct bio bio;
@@ -1481,7 +1480,6 @@ static void __writecache_writeback_pmem(struct dm_writecache *wc, struct writeba
bio->bi_end_io = writecache_writeback_endio;
bio_set_dev(bio, wc->dev->bdev);
bio->bi_iter.bi_sector = read_original_sector(wc, e);
- wb->page_offset = PAGE_SIZE;
if (max_pages <= WB_LIST_INLINE ||
unlikely(!(wb->wc_list = kmalloc_array(max_pages, sizeof(struct wc_entry *),
GFP_NOIO | __GFP_NORETRY |
--
1.8.3.1

2019-04-23 10:41:02

by Mikulas Patocka

Subject: Re: [PATCH] dm-writecache: remove unused member page_offset in writeback_struct

On Sun, 21 Apr 2019, Huaisheng Ye wrote:

> From: Huaisheng Ye <[email protected]>
>
> The structure member page_offset in writeback_struct never has been
> used actually. Remove it.
>
> Signed-off-by: Huaisheng Ye <[email protected]>

Acked-by: Mikulas Patocka <[email protected]>

> ---
> drivers/md/dm-writecache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
> index cfbbfbc..ddf1732 100644
> --- a/drivers/md/dm-writecache.c
> +++ b/drivers/md/dm-writecache.c
> @@ -190,7 +190,6 @@ struct writeback_struct {
> struct dm_writecache *wc;
> struct wc_entry **wc_list;
> unsigned wc_list_n;
> - unsigned page_offset;
> struct page *page;
> struct wc_entry *wc_list_inline[WB_LIST_INLINE];
> struct bio bio;
> @@ -1481,7 +1480,6 @@ static void __writecache_writeback_pmem(struct dm_writecache *wc, struct writeba
> bio->bi_end_io = writecache_writeback_endio;
> bio_set_dev(bio, wc->dev->bdev);
> bio->bi_iter.bi_sector = read_original_sector(wc, e);
> - wb->page_offset = PAGE_SIZE;
> if (max_pages <= WB_LIST_INLINE ||
> unlikely(!(wb->wc_list = kmalloc_array(max_pages, sizeof(struct wc_entry *),
> GFP_NOIO | __GFP_NORETRY |
> --
> 1.8.3.1
>
>