2019-04-20 11:49:42

by Moses Christopher

Subject: [PATCH] staging: unisys: use help instead of ---help--- in Kconfig

From: Moses Christopher <[email protected]>

- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"

Signed-off-by: Moses Christopher <[email protected]>
---
drivers/staging/unisys/Kconfig | 2 +-
drivers/staging/unisys/visorhba/Kconfig | 2 +-
drivers/staging/unisys/visorinput/Kconfig | 2 +-
drivers/staging/unisys/visornic/Kconfig | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig
index c27dab3b610f..b9c814df5d36 100644
--- a/drivers/staging/unisys/Kconfig
+++ b/drivers/staging/unisys/Kconfig
@@ -3,7 +3,7 @@
#
menuconfig UNISYSSPAR
bool "Unisys SPAR driver support"
- ---help---
+ help
Support for the Unisys SPAR drivers

if UNISYSSPAR
diff --git a/drivers/staging/unisys/visorhba/Kconfig b/drivers/staging/unisys/visorhba/Kconfig
index 241d8038261c..4b67634b236d 100644
--- a/drivers/staging/unisys/visorhba/Kconfig
+++ b/drivers/staging/unisys/visorhba/Kconfig
@@ -5,7 +5,7 @@
config UNISYS_VISORHBA
tristate "Unisys visorhba driver"
depends on UNISYSSPAR && UNISYS_VISORBUS && SCSI
- ---help---
+ help
The Unisys visorhba driver provides support for s-Par HBA
devices exposed on the s-Par visorbus. When a message is sent
to visorbus to create a HBA device, the probe function of
diff --git a/drivers/staging/unisys/visorinput/Kconfig b/drivers/staging/unisys/visorinput/Kconfig
index a3817e0f7e5c..c0681f932d76 100644
--- a/drivers/staging/unisys/visorinput/Kconfig
+++ b/drivers/staging/unisys/visorinput/Kconfig
@@ -5,7 +5,7 @@
config UNISYS_VISORINPUT
tristate "Unisys visorinput driver"
depends on UNISYSSPAR && UNISYS_VISORBUS && INPUT
- ---help---
+ help
The Unisys s-Par visorinput driver provides a virtualized system
console (keyboard and mouse) that is accessible through the
s-Par firmware's user interface. s-Par provides video using the EFI
diff --git a/drivers/staging/unisys/visornic/Kconfig b/drivers/staging/unisys/visornic/Kconfig
index 1676dc7072d5..33a9b63bccb5 100644
--- a/drivers/staging/unisys/visornic/Kconfig
+++ b/drivers/staging/unisys/visornic/Kconfig
@@ -5,7 +5,7 @@
config UNISYS_VISORNIC
tristate "Unisys visornic driver"
depends on UNISYSSPAR && UNISYS_VISORBUS && NET
- ---help---
+ help
The Unisys Visornic driver provides support for s-Par network
devices exposed on the s-Par visorbus. When a message is sent
to visorbus to create a network device, the probe function of
--
2.11.0

2019-04-20 21:08:21

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: unisys: use help instead of ---help--- in Kconfig

On Sat, Apr 20, 2019 at 11:46:46AM +0000, MosesChristopher wrote:
> From: Moses Christopher <[email protected]>
>
> - Resolve the following warning from the Kconfig,
> "WARNING: prefer 'help' over '---help---' for new help texts"
>
> Signed-off-by: Moses Christopher <[email protected]>
> ---
> drivers/staging/unisys/Kconfig | 2 +-
> drivers/staging/unisys/visorhba/Kconfig | 2 +-
> drivers/staging/unisys/visorinput/Kconfig | 2 +-
> drivers/staging/unisys/visornic/Kconfig | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)

This, and all of your other ---help--- conversion patches, do not apply
at all as some of these have already been done by others in my tree.
Please rebase all of your help cleanup staging patches against my
staging-next branch and resend any remaining ones that are needed, as
I'm going to drop all of these from my queue right now.

thanks,

greg k-h

2019-04-24 19:44:53

by Dan Carpenter

Subject: Re: [PATCH] staging: unisys: use help instead of ---help--- in Kconfig

On Sat, Apr 20, 2019 at 11:46:46AM +0000, MosesChristopher wrote:
> From: Moses Christopher <[email protected]>
>

Could you Fix your email From header so this isn't required?

regards,
dan carpenter