2019-04-23 11:45:30

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi

From: Ashish Kumar <[email protected]>

This patch is to add esdhc node and enable SD UHS-I,
eMMC HS200 for ls1028ardb/ls1028aqds board.

Signed-off-by: Ashish Kumar <[email protected]>
Signed-off-by: Yangbo Lu <[email protected]>
Signed-off-by: Yinbo Zhu <[email protected]>
---
.../boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++
.../boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++
.../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 +++++++++++++++++++
3 files changed, 48 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 14c79f4691ea..180e5d2a00d1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -42,6 +42,14 @@
status = "okay";
};

+&esdhc {
+ status = "okay";
+};
+
+&esdhc1 {
+ status = "okay";
+};
+
&i2c0 {
status = "okay";

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index f86b054a74ae..1bfaf4294db4 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -30,6 +30,19 @@
};
};

+&esdhc {
+ status = "okay";
+ sd-uhs-sdr104;
+ sd-uhs-sdr50;
+ sd-uhs-sdr25;
+ sd-uhs-sdr12;
+ };
+
+&esdhc1 {
+ status = "okay";
+ mmc-hs200-1_8v;
+ };
+
&i2c0 {
status = "okay";

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 2896bbcfa3bb..d13cd3fb455b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -274,6 +274,33 @@
status = "disabled";
};

+ esdhc: esdhc@2140000 {
+ compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
+ reg = <0x0 0x2140000 0x0 0x10000>;
+ interrupts = <0 28 0x4>; /* Level high type */
+ clock-frequency = <0>;
+ clocks = <&clockgen 2 1>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ little-endian;
+ bus-width = <4>;
+ status = "disabled";
+ };
+
+ esdhc1: esdhc@2150000 {
+ compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
+ reg = <0x0 0x2150000 0x0 0x10000>;
+ interrupts = <0 63 0x4>; /* Level high type */
+ clock-frequency = <0>;
+ clocks = <&clockgen 2 1>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ broken-cd;
+ little-endian;
+ bus-width = <4>;
+ status = "disabled";
+ };
+
sata: sata@3200000 {
compatible = "fsl,ls1028a-ahci";
reg = <0x0 0x3200000 0x0 0x10000>,
--
2.17.1


2019-05-01 17:51:57

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi

On Tue, Apr 23, 2019 at 6:42 AM Yinbo Zhu <[email protected]> wrote:
>
> From: Ashish Kumar <[email protected]>
>
> This patch is to add esdhc node and enable SD UHS-I,
> eMMC HS200 for ls1028ardb/ls1028aqds board.
>
> Signed-off-by: Ashish Kumar <[email protected]>
> Signed-off-by: Yangbo Lu <[email protected]>
> Signed-off-by: Yinbo Zhu <[email protected]>
> ---
> .../boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++
> .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 +++++++++++++++++++
> 3 files changed, 48 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 14c79f4691ea..180e5d2a00d1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -42,6 +42,14 @@
> status = "okay";
> };
>
> +&esdhc {
> + status = "okay";
> +};
> +
> +&esdhc1 {
> + status = "okay";
> +};
> +
> &i2c0 {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index f86b054a74ae..1bfaf4294db4 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -30,6 +30,19 @@
> };
> };
>
> +&esdhc {
> + status = "okay";
> + sd-uhs-sdr104;
> + sd-uhs-sdr50;
> + sd-uhs-sdr25;
> + sd-uhs-sdr12;
> + };
> +
> +&esdhc1 {
> + status = "okay";
> + mmc-hs200-1_8v;
> + };
> +
> &i2c0 {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 2896bbcfa3bb..d13cd3fb455b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -274,6 +274,33 @@
> status = "disabled";
> };
>
> + esdhc: esdhc@2140000 {

mmc@...

> + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> + reg = <0x0 0x2140000 0x0 0x10000>;
> + interrupts = <0 28 0x4>; /* Level high type */
> + clock-frequency = <0>;

Filled in by bootloader? If so, add a comment.

> + clocks = <&clockgen 2 1>;
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + little-endian;
> + bus-width = <4>;
> + status = "disabled";
> + };
> +
> + esdhc1: esdhc@2150000 {

mmc@...

> + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> + reg = <0x0 0x2150000 0x0 0x10000>;
> + interrupts = <0 63 0x4>; /* Level high type */
> + clock-frequency = <0>;
> + clocks = <&clockgen 2 1>;
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + broken-cd;
> + little-endian;
> + bus-width = <4>;
> + status = "disabled";
> + };
> +
> sata: sata@3200000 {
> compatible = "fsl,ls1028a-ahci";
> reg = <0x0 0x3200000 0x0 0x10000>,
> --
> 2.17.1
>

2019-05-05 06:08:20

by Yinbo Zhu

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi



> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: 2019年5月2日 1:50
> To: Yinbo Zhu <[email protected]>
> Cc: Shawn Guo <[email protected]>; Leo Li <[email protected]>; Xiaobo
> Xie <[email protected]>; Mark Rutland <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; Y.b. Lu
> <[email protected]>; Jiafei Pan <[email protected]>; Ashish Kumar
> <[email protected]>
> Subject: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi
>
> Caution: EXT Email
>
> On Tue, Apr 23, 2019 at 6:42 AM Yinbo Zhu <[email protected]> wrote:
> >
> > From: Ashish Kumar <[email protected]>
> >
> > This patch is to add esdhc node and enable SD UHS-I, eMMC HS200 for
> > ls1028ardb/ls1028aqds board.
> >
> > Signed-off-by: Ashish Kumar <[email protected]>
> > Signed-off-by: Yangbo Lu <[email protected]>
> > Signed-off-by: Yinbo Zhu <[email protected]>
> > ---
> > .../boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++
> > .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++
> > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27
> > +++++++++++++++++++
> > 3 files changed, 48 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 14c79f4691ea..180e5d2a00d1 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -42,6 +42,14 @@
> > status = "okay";
> > };
> >
> > +&esdhc {
> > + status = "okay";
> > +};
> > +
> > +&esdhc1 {
> > + status = "okay";
> > +};
> > +
> > &i2c0 {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > index f86b054a74ae..1bfaf4294db4 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > @@ -30,6 +30,19 @@
> > };
> > };
> >
> > +&esdhc {
> > + status = "okay";
> > + sd-uhs-sdr104;
> > + sd-uhs-sdr50;
> > + sd-uhs-sdr25;
> > + sd-uhs-sdr12;
> > + };
> > +
> > +&esdhc1 {
> > + status = "okay";
> > + mmc-hs200-1_8v;
> > + };
> > +
> > &i2c0 {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 2896bbcfa3bb..d13cd3fb455b 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -274,6 +274,33 @@
> > status = "disabled";
> > };
> >
> > + esdhc: esdhc@2140000 {
>
> mmc@...
>
> > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> > + reg = <0x0 0x2140000 0x0 0x10000>;
> > + interrupts = <0 28 0x4>; /* Level high type */
> > + clock-frequency = <0>;
>
> Filled in by bootloader? If so, add a comment.
Hi rob,
Filled in by kernel, please you note.

Regards,
Yinbo.
> > + clocks = <&clockgen 2 1>;
> > + voltage-ranges = <1800 1800 3300 3300>;
> > + sdhci,auto-cmd12;
> > + little-endian;
> > + bus-width = <4>;
> > + status = "disabled";
> > + };
> > +
> > + esdhc1: esdhc@2150000 {
>
> mmc@...
>
> > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> > + reg = <0x0 0x2150000 0x0 0x10000>;
> > + interrupts = <0 63 0x4>; /* Level high type */
> > + clock-frequency = <0>;
> > + clocks = <&clockgen 2 1>;
> > + voltage-ranges = <1800 1800 3300 3300>;
> > + sdhci,auto-cmd12;
> > + broken-cd;
> > + little-endian;
> > + bus-width = <4>;
> > + status = "disabled";
> > + };
> > +
> > sata: sata@3200000 {
> > compatible = "fsl,ls1028a-ahci";
> > reg = <0x0 0x3200000 0x0 0x10000>,
> > --
> > 2.17.1
> >

2019-05-15 03:42:45

by Yinbo Zhu

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi



> -----Original Message-----
> From: Yinbo Zhu
> Sent: 2019年5月5日 14:07
> To: Rob Herring <[email protected]>
> Cc: Shawn Guo <[email protected]>; Leo Li <[email protected]>; Xiaobo
> Xie <[email protected]>; Mark Rutland <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; Y.b. Lu
> <[email protected]>; Jiafei Pan <[email protected]>; Ashish Kumar
> <[email protected]>
> Subject: RE: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in dtsi
>
>
>
> > -----Original Message-----
> > From: Rob Herring [mailto:[email protected]]
> > Sent: 2019年5月2日 1:50
> > To: Yinbo Zhu <[email protected]>
> > Cc: Shawn Guo <[email protected]>; Leo Li <[email protected]>;
> > Xiaobo Xie <[email protected]>; Mark Rutland <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected]; Y.b. Lu
> > <[email protected]>; Jiafei Pan <[email protected]>; Ashish Kumar
> > <[email protected]>
> > Subject: [EXT] Re: [PATCH v1] arm64: ls1028: dtsi: Add esdhc node in
> > dtsi
> >
> > Caution: EXT Email
> >
> > On Tue, Apr 23, 2019 at 6:42 AM Yinbo Zhu <[email protected]> wrote:
> > >
> > > From: Ashish Kumar <[email protected]>
> > >
> > > This patch is to add esdhc node and enable SD UHS-I, eMMC HS200 for
> > > ls1028ardb/ls1028aqds board.
> > >
> > > Signed-off-by: Ashish Kumar <[email protected]>
> > > Signed-off-by: Yangbo Lu <[email protected]>
> > > Signed-off-by: Yinbo Zhu <[email protected]>
> > > ---
> > > .../boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++
> > > .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++
> > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27
> > > +++++++++++++++++++
> > > 3 files changed, 48 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > index 14c79f4691ea..180e5d2a00d1 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > @@ -42,6 +42,14 @@
> > > status = "okay";
> > > };
> > >
> > > +&esdhc {
> > > + status = "okay";
> > > +};
> > > +
> > > +&esdhc1 {
> > > + status = "okay";
> > > +};
> > > +
> > > &i2c0 {
> > > status = "okay";
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > index f86b054a74ae..1bfaf4294db4 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > @@ -30,6 +30,19 @@
> > > };
> > > };
> > >
> > > +&esdhc {
> > > + status = "okay";
> > > + sd-uhs-sdr104;
> > > + sd-uhs-sdr50;
> > > + sd-uhs-sdr25;
> > > + sd-uhs-sdr12;
> > > + };
> > > +
> > > +&esdhc1 {
> > > + status = "okay";
> > > + mmc-hs200-1_8v;
> > > + };
> > > +
> > > &i2c0 {
> > > status = "okay";
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 2896bbcfa3bb..d13cd3fb455b 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -274,6 +274,33 @@
> > > status = "disabled";
> > > };
> > >
> > > + esdhc: esdhc@2140000 {
> >
> > mmc@...
> >
> > > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> > > + reg = <0x0 0x2140000 0x0 0x10000>;
> > > + interrupts = <0 28 0x4>; /* Level high type */
> > > + clock-frequency = <0>;
> >
> > Filled in by bootloader? If so, add a comment.
> Hi rob,
> Filled in by kernel, please you note.
>
> Regards,
> Yinbo.

Hi rob,

I'm sorry, It is fixed up by bootloader actually.
And I will add a commont.

yinbo
> > > + clocks = <&clockgen 2 1>;
> > > + voltage-ranges = <1800 1800 3300 3300>;
> > > + sdhci,auto-cmd12;
> > > + little-endian;
> > > + bus-width = <4>;
> > > + status = "disabled";
> > > + };
> > > +
> > > + esdhc1: esdhc@2150000 {
> >
> > mmc@...
> >
> > > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> > > + reg = <0x0 0x2150000 0x0 0x10000>;
> > > + interrupts = <0 63 0x4>; /* Level high type */
> > > + clock-frequency = <0>;
> > > + clocks = <&clockgen 2 1>;
> > > + voltage-ranges = <1800 1800 3300 3300>;
> > > + sdhci,auto-cmd12;
> > > + broken-cd;
> > > + little-endian;
> > > + bus-width = <4>;
> > > + status = "disabled";
> > > + };
> > > +
> > > sata: sata@3200000 {
> > > compatible = "fsl,ls1028a-ahci";
> > > reg = <0x0 0x3200000 0x0 0x10000>,
> > > --
> > > 2.17.1
> > >