2019-04-23 16:54:52

by Bharath Vedartham

Subject: [PATCH] apparmor: Force type-casting of current->real_cred

This patch fixes the sparse warning:
warning: cast removes address space '<asn:4>' of expression.

Signed-off-by: Bharath Vedartham <[email protected]>
---
security/apparmor/lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index 87500bd..36478c4 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -1529,7 +1529,7 @@ static int param_set_mode(const char *val, const struct kernel_param *kp)
*/
static int __init set_init_ctx(void)
{
- struct cred *cred = (struct cred *)current->real_cred;
+ struct cred *cred = (__force struct cred *)current->real_cred;

set_cred_label(cred, aa_get_label(ns_unconfined(root_ns)));

--
2.7.4

2019-05-07 19:55:03

by John Johansen

Subject: Re: [PATCH] apparmor: Force type-casting of current->real_cred

On 4/23/19 9:53 AM, Bharath Vedartham wrote:
> This patch fixes the sparse warning:
> warning: cast removes address space '<asn:4>' of expression.
>
> Signed-off-by: Bharath Vedartham <[email protected]>


Acked-by: John Johansen <[email protected]>

I will pull this into my tree

> ---
> security/apparmor/lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 87500bd..36478c4 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1529,7 +1529,7 @@ static int param_set_mode(const char *val, const struct kernel_param *kp)
> */
> static int __init set_init_ctx(void)
> {
> - struct cred *cred = (struct cred *)current->real_cred;
> + struct cred *cred = (__force struct cred *)current->real_cred;
>
> set_cred_label(cred, aa_get_label(ns_unconfined(root_ns)));
>
>

Acked-by: John Johansen <[email protected]>