2019-04-26 06:46:54

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the char-misc tree

Hi all,

After merging the char-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/misc/aspeed-p2a-ctrl.c: In function 'aspeed_p2a_mmap':
drivers/misc/aspeed-p2a-ctrl.c:110:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
pgprot_t prot = vma->vm_page_prot;
^~~~~~~~

Introduced by commit

01c60dcea9f7 ("drivers/misc: Add Aspeed P2A control driver")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-04-26 14:31:45

by Patrick Venture

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the char-misc tree

On Thu, Apr 25, 2019 at 11:25 PM Greg KH <[email protected]> wrote:
>
> On Fri, Apr 26, 2019 at 03:56:53PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the char-misc tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/misc/aspeed-p2a-ctrl.c: In function 'aspeed_p2a_mmap':
> > drivers/misc/aspeed-p2a-ctrl.c:110:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> > pgprot_t prot = vma->vm_page_prot;
> > ^~~~~~~~
> >
> > Introduced by commit
> >
> > 01c60dcea9f7 ("drivers/misc: Add Aspeed P2A control driver")
>
> Patrick, I thought you fixed all of these already? Can you send a patch
> again?

I fixed the ones caught by the robot. I'll have to switch up my build
environment a bit to fault on warnings for the kernel, not sure why it
isn't --

>
> Can you also make the driver so it can build with CONFIG_COMPILE_TEST
> enabled so that others can find your problems earlier in the review
> process?

Roger that.

>
> thanks,
>
> greg k-h

2019-04-26 18:03:35

by Patrick Venture

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the char-misc tree

On Fri, Apr 26, 2019 at 7:30 AM Patrick Venture <[email protected]> wrote:
>
> On Thu, Apr 25, 2019 at 11:25 PM Greg KH <[email protected]> wrote:
> >
> > On Fri, Apr 26, 2019 at 03:56:53PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the char-misc tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > drivers/misc/aspeed-p2a-ctrl.c: In function 'aspeed_p2a_mmap':
> > > drivers/misc/aspeed-p2a-ctrl.c:110:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> > > pgprot_t prot = vma->vm_page_prot;
> > > ^~~~~~~~
> > >
> > > Introduced by commit
> > >
> > > 01c60dcea9f7 ("drivers/misc: Add Aspeed P2A control driver")
> >
> > Patrick, I thought you fixed all of these already? Can you send a patch
> > again?
>
> I fixed the ones caught by the robot. I'll have to switch up my build
> environment a bit to fault on warnings for the kernel, not sure why it
> isn't --

Verified the warnings being ignored isn't a local configuration issue,
but the way OpenBMC is configured. Verified the warning via normal
kernel compilation and fixed the issue. Reran and found no other
issues for that drivers. Submitted patch for review.

>
> >
> > Can you also make the driver so it can build with CONFIG_COMPILE_TEST
> > enabled so that others can find your problems earlier in the review
> > process?

Verified the driver builds and produces no warnings.

Thanks,
Patrick

>
> Roger that.
>
> >
> > thanks,
> >
> > greg k-h