2019-04-17 15:15:56

by Arnd Bergmann

Subject: [PATCH v3] ARM: debug-ll: add default address for digicolor

The digicolor platform has three UARTs, but the Kconfig.debug
file explicitly lists port zero as the one to be used for the
console, while not providing any default values.

This can get an automated randconfig build stuck in a loop
waiting for the user to input the number. As we already know
the physical address, this patch provides that number as
default, along with a reasonable default value for the virtual
address.

Cc: Baruch Siach <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/Kconfig.debug | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index a8a1e14f20ab..3e33753bd60c 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1676,6 +1676,7 @@ config DEBUG_UART_PHYS
default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1
default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
default 0xe8008000 if DEBUG_R7S72100_SCIF2
+ default 0xf0000000 if DEBUG_DIGICOLOR_UA0
default 0xf0000be0 if ARCH_EBSA110
default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
@@ -1728,6 +1729,7 @@ config DEBUG_UART_VIRT
default 0xe0010fe0 if ARCH_RPC
default 0xf0000be0 if ARCH_EBSA110
default 0xf0010000 if DEBUG_ASM9260_UART
+ default 0xf0100000 if DEBUG_DIGICOLOR_UA0
default 0xf01fb000 if DEBUG_NOMADIK_UART
default 0xf0201000 if DEBUG_BCM2835 || DEBUG_BCM2836
default 0xf1000300 if DEBUG_BCM_5301X
--
2.20.0

2019-04-17 17:01:52

by Baruch Siach

Subject: Re: [PATCH v3] ARM: debug-ll: add default address for digicolor

Hi Arnd,

On Wed, Apr 17 2019, Arnd Bergmann wrote:
> The digicolor platform has three UARTs, but the Kconfig.debug
> file explicitly lists port zero as the one to be used for the
> console, while not providing any default values.
>
> This can get an automated randconfig build stuck in a loop
> waiting for the user to input the number. As we already know
> the physical address, this patch provides that number as
> default, along with a reasonable default value for the virtual
> address.
>
> Cc: Baruch Siach <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Baruch Siach <[email protected]>

Thanks,
baruch

> ---
> arch/arm/Kconfig.debug | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index a8a1e14f20ab..3e33753bd60c 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1676,6 +1676,7 @@ config DEBUG_UART_PHYS
> default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1
> default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
> default 0xe8008000 if DEBUG_R7S72100_SCIF2
> + default 0xf0000000 if DEBUG_DIGICOLOR_UA0
> default 0xf0000be0 if ARCH_EBSA110
> default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
> default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
> @@ -1728,6 +1729,7 @@ config DEBUG_UART_VIRT
> default 0xe0010fe0 if ARCH_RPC
> default 0xf0000be0 if ARCH_EBSA110
> default 0xf0010000 if DEBUG_ASM9260_UART
> + default 0xf0100000 if DEBUG_DIGICOLOR_UA0
> default 0xf01fb000 if DEBUG_NOMADIK_UART
> default 0xf0201000 if DEBUG_BCM2835 || DEBUG_BCM2836
> default 0xf1000300 if DEBUG_BCM_5301X

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -

2019-04-29 06:57:13

by Olof Johansson

Subject: Re: [PATCH v3] ARM: debug-ll: add default address for digicolor

On Wed, Apr 17, 2019 at 05:13:27PM +0200, Arnd Bergmann wrote:
> The digicolor platform has three UARTs, but the Kconfig.debug
> file explicitly lists port zero as the one to be used for the
> console, while not providing any default values.
>
> This can get an automated randconfig build stuck in a loop
> waiting for the user to input the number. As we already know
> the physical address, this patch provides that number as
> default, along with a reasonable default value for the virtual
> address.
>
> Cc: Baruch Siach <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>

Applied, thanks!


-Olof