2019-04-26 16:43:41

by Yue Haibing

Subject: [PATCH -next] drm/komeda: remove set but not used variable 'kcrtc'

From: YueHaibing <[email protected]>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/arm/display/komeda/komeda_plane.c: In function komeda_plane_atomic_check:
drivers/gpu/drm/arm/display/komeda/komeda_plane.c:49:22: warning: variable kcrtc set but not used [-Wunused-but-set-variable]

It is never used since introduction in
commit 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index 07ed0cc..0753892 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -55,7 +55,6 @@ komeda_plane_atomic_check(struct drm_plane *plane,
struct komeda_plane_state *kplane_st = to_kplane_st(state);
struct komeda_layer *layer = kplane->layer;
struct drm_crtc_state *crtc_st;
- struct komeda_crtc *kcrtc;
struct komeda_crtc_state *kcrtc_st;
struct komeda_data_flow_cfg dflow;
int err;
@@ -73,7 +72,6 @@ komeda_plane_atomic_check(struct drm_plane *plane,
if (!crtc_st->active)
return 0;

- kcrtc = to_kcrtc(state->crtc);
kcrtc_st = to_kcrtc_st(crtc_st);

err = komeda_plane_init_data_flow(state, &dflow);
--
2.7.4

2019-04-29 10:14:40

by James Qian Wang

Subject: Re: [PATCH -next] drm/komeda: remove set but not used variable 'kcrtc'

On Sat, Apr 27, 2019 at 12:42:02AM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c: In function komeda_plane_atomic_check:
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:49:22: warning: variable kcrtc set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in
> commit 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs")
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index 07ed0cc..0753892 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -55,7 +55,6 @@ komeda_plane_atomic_check(struct drm_plane *plane,
> struct komeda_plane_state *kplane_st = to_kplane_st(state);
> struct komeda_layer *layer = kplane->layer;
> struct drm_crtc_state *crtc_st;
> - struct komeda_crtc *kcrtc;
> struct komeda_crtc_state *kcrtc_st;
> struct komeda_data_flow_cfg dflow;
> int err;
> @@ -73,7 +72,6 @@ komeda_plane_atomic_check(struct drm_plane *plane,
> if (!crtc_st->active)
> return 0;
>
> - kcrtc = to_kcrtc(state->crtc);
> kcrtc_st = to_kcrtc_st(crtc_st);
>
> err = komeda_plane_init_data_flow(state, &dflow);
> --
> 2.7.4
>

Thank you for the patch.

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>

@liviu:
Could you help to apply this patch to our tree.

James
--