2019-04-30 05:18:19

by Yinbo Zhu

Subject: [PATCH v1] mmc: dt: add DT bindings for ls1028a eSDHC host controller

From: Yinbo Zhu <[email protected]>

Add "fsl,ls1028a-esdhc" bindings for ls1028a eSDHC host controller

Signed-off-by: Yinbo Zhu <[email protected]>
---
.../devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
index 99c5cf8..a7250b9 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
+++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
@@ -21,6 +21,7 @@ Required properties:
"fsl,ls1043a-esdhc"
"fsl,ls1046a-esdhc"
"fsl,ls2080a-esdhc"
+ "fsl,ls1028a-esdhc"
- clock-frequency : specifies eSDHC base clock frequency.

Optional properties:
--
1.7.1

2019-04-30 23:13:29

by Leo Li

Subject: Re: [PATCH v1] mmc: dt: add DT bindings for ls1028a eSDHC host controller

On Tue, Apr 30, 2019 at 12:16 AM Yinbo Zhu <[email protected]> wrote:
>
> From: Yinbo Zhu <[email protected]>

The patch title better to be "dt-bindings: mmc: ..."
>
> Add "fsl,ls1028a-esdhc" bindings for ls1028a eSDHC host controller
>
> Signed-off-by: Yinbo Zhu <[email protected]>
> ---
> .../devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index 99c5cf8..a7250b9 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -21,6 +21,7 @@ Required properties:
> "fsl,ls1043a-esdhc"
> "fsl,ls1046a-esdhc"
> "fsl,ls2080a-esdhc"
> + "fsl,ls1028a-esdhc"

Better to be alphabetical order.

> - clock-frequency : specifies eSDHC base clock frequency.
>
> Optional properties:
> --
> 1.7.1
>