2019-04-30 20:02:47

by saravanan sekar

[permalink] [raw]
Subject: [PATCH v2] ASoC: tlv320aic3x: Add support for high power analog output

Add support to output level control for the analog high power output
drivers HPOUT and HPCOM.

Signed-off-by: Saravanan Sekar <[email protected]>
---

Notes:
Changes in V2:
- Removed power control as it is handled by DAPM
- Added level control for left channel

sound/soc/codecs/tlv320aic3x.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 516d17cb2182..90f53f9b5c2f 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -324,6 +324,9 @@ static DECLARE_TLV_DB_SCALE(adc_tlv, 0, 50, 0);
*/
static DECLARE_TLV_DB_SCALE(output_stage_tlv, -5900, 50, 1);

+/* HP/HPCOM volumes. From 0 to 9 dB in 1 dB steps */
+static DECLARE_TLV_DB_SCALE(hp_tlv, 0, 100, 0);
+
static const struct snd_kcontrol_new aic3x_snd_controls[] = {
/* Output */
SOC_DOUBLE_R_TLV("PCM Playback Volume",
@@ -419,6 +422,12 @@ static const struct snd_kcontrol_new aic3x_snd_controls[] = {
/* Pop reduction */
SOC_ENUM("Output Driver Power-On time", aic3x_poweron_time_enum),
SOC_ENUM("Output Driver Ramp-up step", aic3x_rampup_step_enum),
+
+ /* Analog HPOUT, HPCOM output level controls */
+ SOC_DOUBLE_R_TLV("HP Playback Volume", HPLOUT_CTRL, HPROUT_CTRL,
+ 4, 9, 0, hp_tlv);
+ SOC_DOUBLE_R_TLV("HPCOM Playback Volume", HPLCOM_CTRL, HPRCOM_CTRL,
+ 4, 9, 0, hp_tlv);
};

/* For other than tlv320aic3104 */
--
2.17.1


2019-05-02 02:11:16

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: tlv320aic3x: Add support for high power analog output

On Tue, Apr 30, 2019 at 10:01:18PM +0200, Saravanan Sekar wrote:
> Add support to output level control for the analog high power output
> drivers HPOUT and HPCOM.
>
> Signed-off-by: Saravanan Sekar <[email protected]>

This doesn't build with current code:

CC sound/soc/codecs/tlv320aic3x.o
sound/soc/codecs/tlv320aic3x.c:428:20: error: expected ‘}’ before ‘;’ token
4, 9, 0, hp_tlv);
^
sound/soc/codecs/tlv320aic3x.c:330:61: note: to match this ‘{’
static const struct snd_kcontrol_new aic3x_snd_controls[] = {
^


Attachments:
(No filename) (639.00 B)
signature.asc (499.00 B)
Download all attachments