2019-05-02 11:04:51

by Manivannan Sadhasivam

Subject: [PATCH] ARM: multi_v7_defconfig: Enable panic and disk LED triggers

Most development boards and devices have one or more LEDs. It is
useful during debugging if they can be wired to show different
behaviours such as disk or cpu activity or a load-average dependent
heartbeat. Enable panic and disk activity triggers so they can be tied
to LED activity during debugging as well.

There was a similar patch which added these triggers for ARM64 as well:
https://patchwork.kernel.org/patch/10042681/

Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2e9fa5312616..466ccc305a05 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,6 +821,8 @@ CONFIG_LEDS_TRIGGER_GPIO=y
CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
CONFIG_LEDS_TRIGGER_TRANSIENT=y
CONFIG_LEDS_TRIGGER_CAMERA=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_DISK=y
CONFIG_EDAC=y
CONFIG_EDAC_HIGHBANK_MC=y
CONFIG_EDAC_HIGHBANK_L2=y
--
2.17.1

2019-05-02 16:47:13

by Amit Kucheria

Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable panic and disk LED triggers

On Thu, May 2, 2019 at 4:33 PM Manivannan Sadhasivam
<[email protected]> wrote:
>
> Most development boards and devices have one or more LEDs. It is
> useful during debugging if they can be wired to show different
> behaviours such as disk or cpu activity or a load-average dependent
> heartbeat. Enable panic and disk activity triggers so they can be tied
> to LED activity during debugging as well.
>
> There was a similar patch which added these triggers for ARM64 as well:
> https://patchwork.kernel.org/patch/10042681/
>
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
Reviewed-by: Amit Kucheria <[email protected]>

> ---
> arch/arm/configs/multi_v7_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 2e9fa5312616..466ccc305a05 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -821,6 +821,8 @@ CONFIG_LEDS_TRIGGER_GPIO=y
> CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
> CONFIG_LEDS_TRIGGER_TRANSIENT=y
> CONFIG_LEDS_TRIGGER_CAMERA=y
> +CONFIG_LEDS_TRIGGER_PANIC=y
> +CONFIG_LEDS_TRIGGER_DISK=y
> CONFIG_EDAC=y
> CONFIG_EDAC_HIGHBANK_MC=y
> CONFIG_EDAC_HIGHBANK_L2=y
> --
> 2.17.1
>