2019-05-03 13:05:37

by Laurentiu Tudor

Subject: [PATCH v3] dpaa_eth: fix SG frame cleanup

From: Laurentiu Tudor <[email protected]>

Fix issue with the entry indexing in the sg frame cleanup code being
off-by-1. This problem showed up when doing some basic iperf tests and
manifested in traffic coming to a halt.

Signed-off-by: Laurentiu Tudor <[email protected]>
Acked-by: Madalin Bucur <[email protected]>
Cc: <[email protected]>
---
v3:
- added cc:stable tag (Joakim)
- pulled from the original patch series and send individually

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index daede7272768..40420edc9ce6 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const struct dpaa_priv *priv,
qm_sg_entry_get_len(&sgt[0]), dma_dir);

/* remaining pages were mapped with skb_frag_dma_map() */
- for (i = 1; i < nr_frags; i++) {
+ for (i = 1; i <= nr_frags; i++) {
WARN_ON(qm_sg_entry_is_ext(&sgt[i]));

dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
--
2.17.1

2019-05-05 17:40:52

by David Miller

Subject: Re: [PATCH v3] dpaa_eth: fix SG frame cleanup

From: [email protected]
Date: Fri, 3 May 2019 16:03:11 +0300

> From: Laurentiu Tudor <[email protected]>
>
> Fix issue with the entry indexing in the sg frame cleanup code being
> off-by-1. This problem showed up when doing some basic iperf tests and
> manifested in traffic coming to a halt.
>
> Signed-off-by: Laurentiu Tudor <[email protected]>
> Acked-by: Madalin Bucur <[email protected]>

Applied and queued up for -stable.