2019-05-04 08:21:54

by Yue Haibing

Subject: [PATCH net-next] netdevsim: Make nsim_num_vf static

Fix sparse warning:

drivers/net/netdevsim/bus.c:253:5: warning:
symbol 'nsim_num_vf' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/netdevsim/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c
index ae48234..868fb9a 100644
--- a/drivers/net/netdevsim/bus.c
+++ b/drivers/net/netdevsim/bus.c
@@ -250,7 +250,7 @@ static int nsim_bus_remove(struct device *dev)
return 0;
}

-int nsim_num_vf(struct device *dev)
+static int nsim_num_vf(struct device *dev)
{
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);

--
2.7.0

2019-05-04 12:16:55

by Jakub Kicinski

Subject: Re: [PATCH net-next] netdevsim: Make nsim_num_vf static

On Sat, 4 May 2019 16:12:07 +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/net/netdevsim/bus.c:253:5: warning:
> symbol 'nsim_num_vf' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

Thanks!

2019-05-05 17:50:27

by David Miller

Subject: Re: [PATCH net-next] netdevsim: Make nsim_num_vf static

From: YueHaibing <[email protected]>
Date: Sat, 4 May 2019 16:12:07 +0800

> Fix sparse warning:
>
> drivers/net/netdevsim/bus.c:253:5: warning:
> symbol 'nsim_num_vf' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Applied.