2019-05-05 07:30:39

by Madhumitha Prabakaran

Subject: [PATCH] Staging: speakup: Replace return type

Replace return type and remove the respective assignment.

Issue found by Coccinelle.

Signed-off-by: Madhumitha Prabakaran <[email protected]>
---
drivers/staging/speakup/i18n.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d36f947..a748eb8052d1 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
input++; /* Advance over %. */
input = skip_flags(input);
input = skip_width(input);
- input = skip_conversion(input);
- return input;
+ return skip_conversion(input);
}

/*
--
2.17.1

2019-05-05 07:36:36

by Samuel Thibault

Subject: Re: [PATCH] Staging: speakup: Replace return type

Hello,

Madhumitha Prabakaran, le dim. 05 mai 2019 02:26:45 -0500, a ecrit:
> Replace return type and remove the respective assignment.

I prefer to keep it the way it was, it looks more straightforward for
the reader.

Samuel

> Issue found by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran <[email protected]>
> ---
> drivers/staging/speakup/i18n.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> input++; /* Advance over %. */
> input = skip_flags(input);
> input = skip_width(input);
> - input = skip_conversion(input);
> - return input;
> + return skip_conversion(input);
> }
>
> /*
> --
> 2.17.1
>

--
Samuel
Progress (n.): The process through which the Internet has evolved from
smart people in front of dumb terminals to dumb people in front of smart
terminals.