2019-05-07 14:40:22

by Philippe Schenker

[permalink] [raw]
Subject: [PATCH 1/5] iio: stmpe-adc: Add compatible name

From: Philippe Schenker <[email protected]>

Add the compatible name to the driver so it gets loaded when the proper
node in DT is detected.

Signed-off-by: Philippe Schenker <[email protected]>
---

drivers/iio/adc/stmpe-adc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
index 37f4b74a5d32..9ec338ba3440 100644
--- a/drivers/iio/adc/stmpe-adc.c
+++ b/drivers/iio/adc/stmpe-adc.c
@@ -354,9 +354,14 @@ static struct platform_driver stmpe_adc_driver = {
.pm = &stmpe_adc_pm_ops,
},
};
-
module_platform_driver(stmpe_adc_driver);

+static const struct of_device_id stmpe_adc_ids[] = {
+ { .compatible = "st,stmpe-adc", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, stmpe_adc_ids);
+
MODULE_AUTHOR("Stefan Agner <[email protected]>");
MODULE_DESCRIPTION("STMPEXXX ADC driver");
MODULE_LICENSE("GPL v2");
--
2.21.0


2019-05-08 07:02:21

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 1/5] iio: stmpe-adc: Add compatible name

On Tue, 07 May 2019, Philippe Schenker wrote:

> From: Philippe Schenker <[email protected]>
>
> Add the compatible name to the driver so it gets loaded when the proper
> node in DT is detected.
>
> Signed-off-by: Philippe Schenker <[email protected]>
> ---
>
> drivers/iio/adc/stmpe-adc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)

Why have you sent this set to me?

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2019-05-08 07:29:17

by Philippe Schenker

[permalink] [raw]
Subject: Re: [PATCH 1/5] iio: stmpe-adc: Add compatible name

On Wed, 2019-05-08 at 08:01 +0100, Lee Jones wrote:
> On Tue, 07 May 2019, Philippe Schenker wrote:
>
> > From: Philippe Schenker <[email protected]>
> >
> > Add the compatible name to the driver so it gets loaded when the proper
> > node in DT is detected.
> >
> > Signed-off-by: Philippe Schenker <[email protected]>
> > ---
> >
> > drivers/iio/adc/stmpe-adc.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
>
> Why have you sent this set to me?
>

get_maintainer.pl returned you as a commit signer. You signed the initial commit
of this driver and pulled it back then because it is part of a mfd.

Philippe

2019-05-11 09:59:29

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 1/5] iio: stmpe-adc: Add compatible name

On Tue, 7 May 2019 16:36:11 +0200
Philippe Schenker <[email protected]> wrote:

> From: Philippe Schenker <[email protected]>
>
> Add the compatible name to the driver so it gets loaded when the proper
> node in DT is detected.
>
> Signed-off-by: Philippe Schenker <[email protected]>
Applied thanks,

Jonathan

> ---
>
> drivers/iio/adc/stmpe-adc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> index 37f4b74a5d32..9ec338ba3440 100644
> --- a/drivers/iio/adc/stmpe-adc.c
> +++ b/drivers/iio/adc/stmpe-adc.c
> @@ -354,9 +354,14 @@ static struct platform_driver stmpe_adc_driver = {
> .pm = &stmpe_adc_pm_ops,
> },
> };
> -
> module_platform_driver(stmpe_adc_driver);
>
> +static const struct of_device_id stmpe_adc_ids[] = {
> + { .compatible = "st,stmpe-adc", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, stmpe_adc_ids);
> +
> MODULE_AUTHOR("Stefan Agner <[email protected]>");
> MODULE_DESCRIPTION("STMPEXXX ADC driver");
> MODULE_LICENSE("GPL v2");