2019-05-06 17:02:16

by Adrian Vladu

Subject: [PATCH] hv: tools: fix KVP and VSS daemons exit code

HyperV KVP and VSS daemons should exit with 0 when the '--help'
or '-h' flags are used.

Signed-off-by: Adrian Vladu <[email protected]>

Cc: "K. Y. Srinivasan" <[email protected]>
Cc: Haiyang Zhang <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Sasha Levin <[email protected]>
Cc: Alessandro Pilotti <[email protected]>
---
tools/hv/hv_kvp_daemon.c | 2 ++
tools/hv/hv_vss_daemon.c | 2 ++
2 files changed, 4 insertions(+)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 8a240b31822b..f5597503c771 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -1386,6 +1386,8 @@ int main(int argc, char *argv[])
daemonize = 0;
break;
case 'h':
+ print_usage(argv);
+ exit(0);
default:
print_usage(argv);
exit(EXIT_FAILURE);
diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index 3abd293c2a35..b58c4bbc0a26 100644
--- a/tools/hv/hv_vss_daemon.c
+++ b/tools/hv/hv_vss_daemon.c
@@ -229,6 +229,8 @@ int main(int argc, char *argv[])
daemonize = 0;
break;
case 'h':
+ print_usage(argv);
+ exit(0);
default:
print_usage(argv);
exit(EXIT_FAILURE);
--
2.19.1

2019-05-09 01:10:01

by Sasha Levin

Subject: Re: [PATCH] hv: tools: fix KVP and VSS daemons exit code

On Mon, May 06, 2019 at 04:50:58PM +0000, Adrian Vladu wrote:
>HyperV KVP and VSS daemons should exit with 0 when the '--help'
>or '-h' flags are used.
>
>Signed-off-by: Adrian Vladu <[email protected]>
>
>Cc: "K. Y. Srinivasan" <[email protected]>
>Cc: Haiyang Zhang <[email protected]>
>Cc: Stephen Hemminger <[email protected]>
>Cc: Sasha Levin <[email protected]>
>Cc: Alessandro Pilotti <[email protected]>

Queued for hyperv-fixes, thanks!

--
Thanks,
Sasha