2019-05-07 23:14:45

by Alakesh Haloi

Subject: [PATCH] selftests/bpf: Fix compile warning in bpf selftest

This fixes the following compile time warning

flow_dissector_load.c: In function ‘detach_program’:
flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security]
error(1, errno, command);
^~~~~~~
Signed-off-by: Alakesh Haloi <[email protected]>
---
tools/testing/selftests/bpf/flow_dissector_load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c
index 77cafa66d048..7136ab9ffa73 100644
--- a/tools/testing/selftests/bpf/flow_dissector_load.c
+++ b/tools/testing/selftests/bpf/flow_dissector_load.c
@@ -52,7 +52,7 @@ static void detach_program(void)
sprintf(command, "rm -r %s", cfg_pin_path);
ret = system(command);
if (ret)
- error(1, errno, command);
+ error(1, errno, "%s", command);
}

static void parse_opts(int argc, char **argv)
--
2.17.1

2019-05-09 20:54:26

by Alexei Starovoitov

Subject: Re: [PATCH] selftests/bpf: Fix compile warning in bpf selftest

On Tue, May 7, 2019 at 4:12 PM Alakesh Haloi <[email protected]> wrote:
>
> This fixes the following compile time warning
>
> flow_dissector_load.c: In function ‘detach_program’:
> flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security]
> error(1, errno, command);
> ^~~~~~~
> Signed-off-by: Alakesh Haloi <[email protected]>
> ---
> tools/testing/selftests/bpf/flow_dissector_load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c
> index 77cafa66d048..7136ab9ffa73 100644
> --- a/tools/testing/selftests/bpf/flow_dissector_load.c
> +++ b/tools/testing/selftests/bpf/flow_dissector_load.c
> @@ -52,7 +52,7 @@ static void detach_program(void)
> sprintf(command, "rm -r %s", cfg_pin_path);
> ret = system(command);
> if (ret)
> - error(1, errno, command);
> + error(1, errno, "%s", command);
> }

it was fixed month ago.

2019-05-10 00:01:55

by Alakesh Haloi

Subject: Re: [PATCH] selftests/bpf: Fix compile warning in bpf selftest

On Thu, May 09, 2019 at 01:51:54PM -0700, Alexei Starovoitov wrote:
> On Tue, May 7, 2019 at 4:12 PM Alakesh Haloi <[email protected]> wrote:
> >
> > This fixes the following compile time warning
> >
> > flow_dissector_load.c: In function ‘detach_program’:
> > flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security]
> > error(1, errno, command);
> > ^~~~~~~
> > Signed-off-by: Alakesh Haloi <[email protected]>
> > ---
> > tools/testing/selftests/bpf/flow_dissector_load.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c
> > index 77cafa66d048..7136ab9ffa73 100644
> > --- a/tools/testing/selftests/bpf/flow_dissector_load.c
> > +++ b/tools/testing/selftests/bpf/flow_dissector_load.c
> > @@ -52,7 +52,7 @@ static void detach_program(void)
> > sprintf(command, "rm -r %s", cfg_pin_path);
> > ret = system(command);
> > if (ret)
> > - error(1, errno, command);
> > + error(1, errno, "%s", command);
> > }
>
> it was fixed month ago.
The warning is seen in mainline. I did not try bpf tree. Looks like it
is fixed there.

Thanks
-Alakesh