2019-05-10 07:32:32

by Yue Haibing

[permalink] [raw]
Subject: [PATCH] power: supply: ucs1002: Fix build error without CONFIG_REGULATOR

Fix gcc build error while CONFIG_REGULATOR is not set

drivers/power/supply/ucs1002_power.o: In function `ucs1002_probe':
drivers/power/supply/ucs1002_power.c:593: undefined reference to `devm_regulator_register'
drivers/power/supply/ucs1002_power.o:(.rodata+0x3b8): undefined reference to `regulator_enable_regmap'
drivers/power/supply/ucs1002_power.o:(.rodata+0x3c0): undefined reference to `regulator_disable_regmap'
drivers/power/supply/ucs1002_power.o:(.rodata+0x3c8): undefined reference to `regulator_is_enabled_regmap'

Add Kconfig dependency to CONFIG_REGULATOR.

Reported-by: Hulk Robot <[email protected]>
Fixes: 9a2688e42638 ("power: supply: Add driver for Microchip UCS1002")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index ef36bd2..26dacda 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -682,6 +682,7 @@ config CHARGER_UCS1002
tristate "Microchip UCS1002 USB Port Power Controller"
depends on I2C
depends on OF
+ depends on REGULATOR
select REGMAP_I2C
help
Say Y to enable support for Microchip UCS1002 Programmable
--
2.7.4



2019-05-10 13:08:03

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] power: supply: ucs1002: Fix build error without CONFIG_REGULATOR

On 5/10/19 12:18 AM, YueHaibing wrote:
> Fix gcc build error while CONFIG_REGULATOR is not set
>
> drivers/power/supply/ucs1002_power.o: In function `ucs1002_probe':
> drivers/power/supply/ucs1002_power.c:593: undefined reference to `devm_regulator_register'
> drivers/power/supply/ucs1002_power.o:(.rodata+0x3b8): undefined reference to `regulator_enable_regmap'
> drivers/power/supply/ucs1002_power.o:(.rodata+0x3c0): undefined reference to `regulator_disable_regmap'
> drivers/power/supply/ucs1002_power.o:(.rodata+0x3c8): undefined reference to `regulator_is_enabled_regmap'
>
> Add Kconfig dependency to CONFIG_REGULATOR.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 9a2688e42638 ("power: supply: Add driver for Microchip UCS1002")
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/power/supply/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index ef36bd2..26dacda 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -682,6 +682,7 @@ config CHARGER_UCS1002
> tristate "Microchip UCS1002 USB Port Power Controller"
> depends on I2C
> depends on OF
> + depends on REGULATOR
> select REGMAP_I2C
> help
> Say Y to enable support for Microchip UCS1002 Programmable
>

2019-05-10 16:24:20

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] power: supply: ucs1002: Fix build error without CONFIG_REGULATOR

Hi,

On Fri, May 10, 2019 at 06:05:06AM -0700, Guenter Roeck wrote:
> On 5/10/19 12:18 AM, YueHaibing wrote:
> > Fix gcc build error while CONFIG_REGULATOR is not set
> >
> > drivers/power/supply/ucs1002_power.o: In function `ucs1002_probe':
> > drivers/power/supply/ucs1002_power.c:593: undefined reference to `devm_regulator_register'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3b8): undefined reference to `regulator_enable_regmap'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3c0): undefined reference to `regulator_disable_regmap'
> > drivers/power/supply/ucs1002_power.o:(.rodata+0x3c8): undefined reference to `regulator_is_enabled_regmap'
> >
> > Add Kconfig dependency to CONFIG_REGULATOR.
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Fixes: 9a2688e42638 ("power: supply: Add driver for Microchip UCS1002")
> > Signed-off-by: YueHaibing <[email protected]>
>
> Reviewed-by: Guenter Roeck <[email protected]>

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (0.98 kB)
 signature.asc (849.00 B)
 Download all attachments