2019-05-12 03:54:01

by Kelsey

Subject: [PATCH] selftests: bpf: Add files generated when compiled to .gitignore

The following files are generated when /selftests/bpf/ is compiled and
should be added to .gitignore:

- libbpf.pc
- libbpf.so.0
- libbpf.so.0.0.3

Signed-off-by: Kelsey Skunberg <[email protected]>
---
tools/testing/selftests/bpf/.gitignore | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
index 41e8a689aa77..ceb11f98fe4f 100644
--- a/tools/testing/selftests/bpf/.gitignore
+++ b/tools/testing/selftests/bpf/.gitignore
@@ -32,3 +32,6 @@ test_tcpnotify_user
test_libbpf
test_tcp_check_syncookie_user
alu32
+libbpf.pc
+libbpf.so.0
+libbpf.so.0.0.3
--
2.20.1

2019-05-12 06:30:18

by Stanislav Fomichev

Subject: Re: [PATCH] selftests: bpf: Add files generated when compiled to .gitignore

On 05/11, Kelsey Skunberg wrote:
> The following files are generated when /selftests/bpf/ is compiled and
> should be added to .gitignore:
>
> - libbpf.pc
> - libbpf.so.0
> - libbpf.so.0.0.3
>
> Signed-off-by: Kelsey Skunberg <[email protected]>
> ---
> tools/testing/selftests/bpf/.gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index 41e8a689aa77..ceb11f98fe4f 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -32,3 +32,6 @@ test_tcpnotify_user
> test_libbpf
> test_tcp_check_syncookie_user
> alu32
> +libbpf.pc

[..]
> +libbpf.so.0
> +libbpf.so.0.0.3
How about libbpf.so.* so we don't have to update it on every release?

> --
> 2.20.1
>

2019-05-12 07:35:51

by Kelsey

Subject: Re: [PATCH] selftests: bpf: Add files generated when compiled to .gitignore

On Sat, May 11, 2019 at 11:29:07PM -0700, Stanislav Fomichev wrote:
> On 05/11, Kelsey Skunberg wrote:
> > The following files are generated when /selftests/bpf/ is compiled and
> > should be added to .gitignore:
> >
> > - libbpf.pc
> > - libbpf.so.0
> > - libbpf.so.0.0.3
> >
> > Signed-off-by: Kelsey Skunberg <[email protected]>
> > ---
> > tools/testing/selftests/bpf/.gitignore | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> > index 41e8a689aa77..ceb11f98fe4f 100644
> > --- a/tools/testing/selftests/bpf/.gitignore
> > +++ b/tools/testing/selftests/bpf/.gitignore
> > @@ -32,3 +32,6 @@ test_tcpnotify_user
> > test_libbpf
> > test_tcp_check_syncookie_user
> > alu32
> > +libbpf.pc
>
> [..]
> > +libbpf.so.0
> > +libbpf.so.0.0.3
> How about libbpf.so.* so we don't have to update it on every release?
>

That seems logical. Updated in v2. I appreciate the feedback!

Cheers,
Kelsey

> > --
> > 2.20.1
> >