2019-05-12 12:26:05

by Hariprasad Kelam

Subject: [PATCH] staging: rtl8723bs: core fix warning Comparison to bool

fix below issue reported by coccicheck

drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison
to bool

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 5f78f1e..d26d8cf 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1672,7 +1672,7 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
roam_target = pmlmepriv->roam_network;
}

- if (roam == true) {
+ if (roam) {
if (rtw_to_roam(adapter) > 0)
rtw_dec_to_roam(adapter); /* this stadel_event is caused by roaming, decrease to_roam */
else if (rtw_to_roam(adapter) == 0)
--
2.7.4

2019-05-13 09:57:43

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8723bs: core fix warning Comparison to bool

On Sun, May 12, 2019 at 05:54:49PM +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison
> to bool
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

You sent 3 patches that do different things, yet have the same subject
line :(

Please fix up and send as a numbered patch series, or better yet, fix
the same thing in the whole file all at ince.

thanks,

greg k-h