2019-04-29 15:21:31

by Geert Uytterhoeven

Subject: [PATCH 1/5] irqchip/renesas-irqc: Remove unneeded inclusion of <linux/spinlock.h>

The driver never used spinlocks, and thus does not need to include
<linux/spinlock.h>.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/irqchip/irq-renesas-irqc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
index a449a7c839b3ec08..438a063c76156d98 100644
--- a/drivers/irqchip/irq-renesas-irqc.c
+++ b/drivers/irqchip/irq-renesas-irqc.c
@@ -7,7 +7,6 @@

#include <linux/init.h>
#include <linux/platform_device.h>
-#include <linux/spinlock.h>
#include <linux/interrupt.h>
#include <linux/ioport.h>
#include <linux/io.h>
--
2.17.1

2019-05-13 13:38:49

by Simon Horman

Subject: Re: [PATCH 1/5] irqchip/renesas-irqc: Remove unneeded inclusion of <linux/spinlock.h>

On Mon, Apr 29, 2019 at 05:20:02PM +0200, Geert Uytterhoeven wrote:
> The driver never used spinlocks, and thus does not need to include
> <linux/spinlock.h>.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

> ---
> drivers/irqchip/irq-renesas-irqc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> index a449a7c839b3ec08..438a063c76156d98 100644
> --- a/drivers/irqchip/irq-renesas-irqc.c
> +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -7,7 +7,6 @@
>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> -#include <linux/spinlock.h>
> #include <linux/interrupt.h>
> #include <linux/ioport.h>
> #include <linux/io.h>
> --
> 2.17.1
>