2019-05-15 13:45:08

by Naveen Kumar Parna

[permalink] [raw]
Subject: [PATCH 2/2] bsr: "foo * bar" should be "foo *bar"

From: Naveen Kumar Parna <[email protected]>

Fixed the checkpatch error. Used "foo *bar" instead of "foo * bar"

Signed-off-by: Naveen Kumar Parna <[email protected]>
---
drivers/char/bsr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index 2b00748b83d2..35d456716969 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -147,7 +147,7 @@ static int bsr_mmap(struct file *filp, struct vm_area_struct *vma)
return 0;
}

-static int bsr_open(struct inode * inode, struct file * filp)
+static int bsr_open(struct inode *inode, struct file *filp)
{
struct cdev *cdev = inode->i_cdev;
struct bsr_dev *dev = container_of(cdev, struct bsr_dev, bsr_cdev);
--
2.17.1


2019-05-15 15:17:12

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 2/2] bsr: "foo * bar" should be "foo *bar"

On Wed, May 15, 2019 at 07:13:10PM +0530, [email protected] wrote:
> From: Naveen Kumar Parna <[email protected]>
>
> Fixed the checkpatch error. Used "foo *bar" instead of "foo * bar"
>
> Signed-off-by: Naveen Kumar Parna <[email protected]>
> ---
> drivers/char/bsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Where is patch 1/2 of this series?

2019-05-16 18:48:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 2/2] bsr: "foo * bar" should be "foo *bar"

On Thu, May 16, 2019 at 11:11:21PM +0530, Naveen Kumar Parna wrote:
> On Wed, 15 May, 2019, 8:44 PM Greg KH, <[email protected]> wrote:
>
> > On Wed, May 15, 2019 at 07:13:10PM +0530, [email protected]
> > wrote:
> > > From: Naveen Kumar Parna <[email protected]>
> > >
> > > Fixed the checkpatch error. Used "foo *bar" instead of "foo * bar"
> > >
> > > Signed-off-by: Naveen Kumar Parna <[email protected]>
> > > ---
> > > drivers/char/bsr.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Where is patch 1/2 of this series?
> >
> It does not has corresponding 1/2 patch. By mistake I used
> wrong argument to 'git format-patch' command.

Ok, thanks, now dropped. Please fix up and resend properly.

As I said before, the bar for cleanup patches outside of
drivers/staging/ is much higher :)

thanks,

greg k-h