2019-04-10 08:41:08

by Baolin Wang

Subject: [PATCH] arm64: dts: sprd: Add clock properties for serial devices

We've introduced power management logics for the Spreadtrum serial
controller by commit 062ec2774c8a ("serial: sprd: Add power management
for the Spreadtrum serial controller"), thus add related clock properties
to support this feature.

Signed-off-by: Baolin Wang <[email protected]>
---
arch/arm64/boot/dts/sprd/whale2.dtsi | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi
index 34b6ca0..b5c5dce 100644
--- a/arch/arm64/boot/dts/sprd/whale2.dtsi
+++ b/arch/arm64/boot/dts/sprd/whale2.dtsi
@@ -75,7 +75,9 @@
"sprd,sc9836-uart";
reg = <0x0 0x100>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&ext_26m>;
+ clock-names = "enable", "uart", "source";
+ clocks = <&apapb_gate CLK_UART0_EB>,
+ <&ap_clk CLK_UART0>, <&ext_26m>;
status = "disabled";
};

@@ -84,7 +86,9 @@
"sprd,sc9836-uart";
reg = <0x100000 0x100>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&ext_26m>;
+ clock-names = "enable", "uart", "source";
+ clocks = <&apapb_gate CLK_UART1_EB>,
+ <&ap_clk CLK_UART1>, <&ext_26m>;
status = "disabled";
};

@@ -93,7 +97,9 @@
"sprd,sc9836-uart";
reg = <0x200000 0x100>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&ext_26m>;
+ clock-names = "enable", "uart", "source";
+ clocks = <&apapb_gate CLK_UART2_EB>,
+ <&ap_clk CLK_UART2>, <&ext_26m>;
status = "disabled";
};

@@ -102,7 +108,9 @@
"sprd,sc9836-uart";
reg = <0x300000 0x100>;
interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&ext_26m>;
+ clock-names = "enable", "uart", "source";
+ clocks = <&apapb_gate CLK_UART3_EB>,
+ <&ap_clk CLK_UART3>, <&ext_26m>;
status = "disabled";
};
};
--
1.7.9.5

2019-05-06 06:39:53

by Baolin Wang

Subject: Re: [PATCH] arm64: dts: sprd: Add clock properties for serial devices

Hi Olof,

On Wed, 10 Apr 2019 at 15:23, Baolin Wang <[email protected]> wrote:
>
> We've introduced power management logics for the Spreadtrum serial
> controller by commit 062ec2774c8a ("serial: sprd: Add power management
> for the Spreadtrum serial controller"), thus add related clock properties
> to support this feature.
>
> Signed-off-by: Baolin Wang <[email protected]>
> ---

Could you take this patch through the arm-soc tree if no objections
from you? Thanks.

> arch/arm64/boot/dts/sprd/whale2.dtsi | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi
> index 34b6ca0..b5c5dce 100644
> --- a/arch/arm64/boot/dts/sprd/whale2.dtsi
> +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi
> @@ -75,7 +75,9 @@
> "sprd,sc9836-uart";
> reg = <0x0 0x100>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ext_26m>;
> + clock-names = "enable", "uart", "source";
> + clocks = <&apapb_gate CLK_UART0_EB>,
> + <&ap_clk CLK_UART0>, <&ext_26m>;
> status = "disabled";
> };
>
> @@ -84,7 +86,9 @@
> "sprd,sc9836-uart";
> reg = <0x100000 0x100>;
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ext_26m>;
> + clock-names = "enable", "uart", "source";
> + clocks = <&apapb_gate CLK_UART1_EB>,
> + <&ap_clk CLK_UART1>, <&ext_26m>;
> status = "disabled";
> };
>
> @@ -93,7 +97,9 @@
> "sprd,sc9836-uart";
> reg = <0x200000 0x100>;
> interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ext_26m>;
> + clock-names = "enable", "uart", "source";
> + clocks = <&apapb_gate CLK_UART2_EB>,
> + <&ap_clk CLK_UART2>, <&ext_26m>;
> status = "disabled";
> };
>
> @@ -102,7 +108,9 @@
> "sprd,sc9836-uart";
> reg = <0x300000 0x100>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ext_26m>;
> + clock-names = "enable", "uart", "source";
> + clocks = <&apapb_gate CLK_UART3_EB>,
> + <&ap_clk CLK_UART3>, <&ext_26m>;
> status = "disabled";
> };
> };
> --
> 1.7.9.5
>


--
Baolin Wang
Best Regards

2019-05-17 00:36:23

by Olof Johansson

Subject: Re: [PATCH] arm64: dts: sprd: Add clock properties for serial devices

On Wed, Apr 10, 2019 at 03:22:50PM +0800, Baolin Wang wrote:
> We've introduced power management logics for the Spreadtrum serial
> controller by commit 062ec2774c8a ("serial: sprd: Add power management
> for the Spreadtrum serial controller"), thus add related clock properties
> to support this feature.
>
> Signed-off-by: Baolin Wang <[email protected]>

Applied to arm/late.


-Olof