2019-05-22 09:56:09

by Bharath Vedartham

Subject: [PATCH] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc

Replace kmalloc + memcpy with kmemdup.

This was reported by coccinelle.

Signed-off-by: Bharath Vedartham <[email protected]>
---
drivers/message/fusion/mptbase.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index d8882b0..37876a7 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
if (mpt_config(ioc, &cfg) != 0)
goto out;

- mem = kmalloc(iocpage2sz, GFP_KERNEL);
+ mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);
if (!mem) {
rc = -ENOMEM;
goto out;
}

- memcpy(mem, (u8 *)pIoc2, iocpage2sz);
ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem;

mpt_read_ioc_pg_3(ioc);
--
2.7.4

2019-05-22 11:49:58

by Joe Perches

Subject: Re: [PATCH] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc

On Wed, 2019-05-22 at 15:23 +0530, Bharath Vedartham wrote:
> Replace kmalloc + memcpy with kmemdup.
> This was reported by coccinelle.
[]
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
[]
> @@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
> if (mpt_config(ioc, &cfg) != 0)
> goto out;
>
> - mem = kmalloc(iocpage2sz, GFP_KERNEL);
> + mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);

You should remove the unnecessary cast here.

2019-05-22 17:37:48

by Bharath Vedartham

Subject: Re: [PATCH] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc

On Wed, May 22, 2019 at 04:48:33AM -0700, Joe Perches wrote:
> On Wed, 2019-05-22 at 15:23 +0530, Bharath Vedartham wrote:
> > Replace kmalloc + memcpy with kmemdup.
> > This was reported by coccinelle.
> []
> > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> []
> > @@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
> > if (mpt_config(ioc, &cfg) != 0)
> > goto out;
> >
> > - mem = kmalloc(iocpage2sz, GFP_KERNEL);
> > + mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);
>
> You should remove the unnecessary cast here.
>
>
Yes! I will change this in v2.

Thanks
Bharath