2019-05-23 06:52:09

by Mathieu Malaterre

Subject: [PATCH] powerpc/32s: Include <linux/moduleloader.h> header file to fix a warning

In commit 2edb16efc899 ("powerpc/32: Add KASAN support") support for
KASAN has been added. However building it as module leads to (warning
treated as error with W=1):

arch/powerpc/mm/kasan/kasan_init_32.c:135:7: error: no previous prototype for 'module_alloc' [-Werror=missing-prototypes]

Make sure to include <linux/moduleloader.h> to provide the following
prototype: module_alloc.

Signed-off-by: Mathieu Malaterre <[email protected]>
---
arch/powerpc/mm/kasan/kasan_init_32.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c
index 0d62be3cba47..0c31e440d094 100644
--- a/arch/powerpc/mm/kasan/kasan_init_32.c
+++ b/arch/powerpc/mm/kasan/kasan_init_32.c
@@ -7,6 +7,7 @@
#include <linux/memblock.h>
#include <linux/sched/task.h>
#include <linux/vmalloc.h>
+#include <linux/moduleloader.h>
#include <asm/pgalloc.h>
#include <asm/code-patching.h>
#include <mm/mmu_decl.h>
--
2.20.1

2019-05-23 06:55:43

by Christophe Leroy

Subject: Re: [PATCH] powerpc/32s: Include <linux/moduleloader.h> header file to fix a warning

Le 23/05/2019 à 08:49, Mathieu Malaterre a écrit :
> In commit 2edb16efc899 ("powerpc/32: Add KASAN support") support for
> KASAN has been added. However building it as module leads to (warning
> treated as error with W=1):
>
> arch/powerpc/mm/kasan/kasan_init_32.c:135:7: error: no previous prototype for 'module_alloc' [-Werror=missing-prototypes]
>
> Make sure to include <linux/moduleloader.h> to provide the following
> prototype: module_alloc.
>
> Signed-off-by: Mathieu Malaterre <[email protected]>

Fixes: 2edb16efc899 ("powerpc/32: Add KASAN support")
Reviewed-by: Christophe Leroy <[email protected]>

> ---
> arch/powerpc/mm/kasan/kasan_init_32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c
> index 0d62be3cba47..0c31e440d094 100644
> --- a/arch/powerpc/mm/kasan/kasan_init_32.c
> +++ b/arch/powerpc/mm/kasan/kasan_init_32.c
> @@ -7,6 +7,7 @@
> #include <linux/memblock.h>
> #include <linux/sched/task.h>
> #include <linux/vmalloc.h>
> +#include <linux/moduleloader.h>
> #include <asm/pgalloc.h>
> #include <asm/code-patching.h>
> #include <mm/mmu_decl.h>
>