2019-05-23 10:22:51

by Greg Kroah-Hartman

Subject: Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

On Thu, May 23, 2019 at 10:10:52AM +0000, TonyWWang-oc wrote:
> --- /dev/null
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: GPL-2.0

Nice, but:

> +/*
> + * Zhaoxin Processor Support for Linux
> + *
> + * Copyright (c) 2019 Shanghai Zhaoxin Semiconductor Co., Ltd.
> + *
> + * Author: David Wang <[email protected]>
> + *
> + * This file is licensed under the terms of the GNU General
> + * License v2.0 or later. See file COPYING for details.

That contridicts the first line of the file :(

Please sort this out with your lawyers and resend it corrected.

Also, gpl "boilerplate" text like this does not need to be in the file
if you just include the spdx line.

thanks,

greg k-h

2019-05-24 08:29:17

by Tony W Wang-oc

Subject: 答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

On Thu, May 23, 2019, [email protected] wrote:
>> + * This file is licensed under the terms of the GNU General
>> + * License v2.0 or later. See file COPYING for details.
>
>That contridicts the first line of the file :(
>
>Please sort this out with your lawyers and resend it corrected.
>
>Also, gpl "boilerplate" text like this does not need to be in the file
>if you just include the spdx line.

Ok, I will sort this out with our lawyers, then adjust this text correctly
before resend it.

Thanks
TonyWWang-oc