2019-05-23 16:58:06

by Bharath Vedartham

Subject: [PATCH] 9p/vfs_super.c: Remove unused parameter data in v9fs_fill_super

v9fs_fill_super has a param 'void *data' which is unused in the
function.

This patch removes the 'void *data' param in v9fs_fill_super and changes
the parameters in all function calls of v9fs_fill_super.

Signed-off-by: Bharath Vedartham <[email protected]>
---
fs/9p/vfs_super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
index 67d1b96..00f2078 100644
--- a/fs/9p/vfs_super.c
+++ b/fs/9p/vfs_super.c
@@ -73,7 +73,7 @@ static int v9fs_set_super(struct super_block *s, void *data)

static int
v9fs_fill_super(struct super_block *sb, struct v9fs_session_info *v9ses,
- int flags, void *data)
+ int flags)
{
int ret;

@@ -143,7 +143,7 @@ static struct dentry *v9fs_mount(struct file_system_type *fs_type, int flags,
retval = PTR_ERR(sb);
goto clunk_fid;
}
- retval = v9fs_fill_super(sb, v9ses, flags, data);
+ retval = v9fs_fill_super(sb, v9ses, flags);
if (retval)
goto release_sb;

--
2.7.4

2019-09-03 11:18:20

by Dominique Martinet

Subject: Re: [PATCH] 9p/vfs_super.c: Remove unused parameter data in v9fs_fill_super

Bharath Vedartham wrote on Thu, May 23, 2019:
> v9fs_fill_super has a param 'void *data' which is unused in the
> function.
>
> This patch removes the 'void *data' param in v9fs_fill_super and changes
> the parameters in all function calls of v9fs_fill_super.
>
> Signed-off-by: Bharath Vedartham <[email protected]>

I just realized I had never replied to this patch - queued it today, as
well as the other you had sent around the same period.

Sorry for the delay, and thanks for sending patches - I don't
particularily care for cleanup like this one but it's always good to
take.

--
Dominique