2019-05-23 23:50:27

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the net-next tree

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_set_multicast_list':
drivers/net/ethernet/xilinx/ll_temac_main.c:490:8: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
while (i < MULTICAST_CAM_TABLE_NUM) {
^

Introduced by commit

1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-05-24 05:28:15

by Esben Haabendal

[permalink] [raw]
Subject: [PATCH] net: ll_temac: Fix compile error

Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")
Signed-off-by: Esben Haabendal <[email protected]>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 22a52b884821..21c1b4322ea7 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -452,7 +452,7 @@ static void temac_set_multicast_list(struct net_device *ndev)
{
struct temac_local *lp = netdev_priv(ndev);
u32 multi_addr_msw, multi_addr_lsw;
- int i;
+ int i = 0;
unsigned long flags;
bool promisc_mode_disabled = false;

@@ -468,7 +468,6 @@ static void temac_set_multicast_list(struct net_device *ndev)
if (!netdev_mc_empty(ndev)) {
struct netdev_hw_addr *ha;

- i = 0;
netdev_for_each_mc_addr(ha, ndev) {
if (WARN_ON(i >= MULTICAST_CAM_TABLE_NUM))
break;
--
2.21.0

2019-05-24 05:32:01

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: ll_temac: Fix compile error

From: Esben Haabendal <[email protected]>
Date: Fri, 24 May 2019 07:24:42 +0200

> Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")
> Signed-off-by: Esben Haabendal <[email protected]>

Applied.