2019-05-24 09:23:29

by Lowry Li (Arm Technology China)

Subject: [PATCH] drm/komeda: Creates plane alpha and blend mode properties

From: "Lowry Li (Arm Technology China)" <[email protected]>

Creates plane alpha and blend mode properties attached to plane.

This patch depends on:
- https://patchwork.freedesktop.org/series/59915/
- https://patchwork.freedesktop.org/series/58665/
- https://patchwork.freedesktop.org/series/59000/
- https://patchwork.freedesktop.org/series/59002/
- https://patchwork.freedesktop.org/series/59471/

Changes since v1:
- Adds patch denpendency in the comment

Changes since v2:
- Remove [RFC] from the subject

Changes since v3:
- Rebase the code

Signed-off-by: Lowry Li (Arm Technology China) <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index e7cd690..9b87c25 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -303,6 +303,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,

drm_plane_helper_add(plane, &komeda_plane_helper_funcs);

+ err = drm_plane_create_alpha_property(plane);
+ if (err)
+ goto cleanup;
+
+ err = drm_plane_create_blend_mode_property(plane,
+ BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+ BIT(DRM_MODE_BLEND_PREMULTI) |
+ BIT(DRM_MODE_BLEND_COVERAGE));
+ if (err)
+ goto cleanup;
+
err = komeda_plane_create_layer_properties(kplane, layer);
if (err)
goto cleanup;
--
1.9.1

2019-05-24 10:52:03

by James Qian Wang

Subject: Re: [PATCH] drm/komeda: Creates plane alpha and blend mode properties

On Fri, May 24, 2019 at 05:20:24PM +0800, Lowry Li (Arm Technology China) wrote:
> From: "Lowry Li (Arm Technology China)" <[email protected]>
>
> Creates plane alpha and blend mode properties attached to plane.
>
> This patch depends on:
> - https://patchwork.freedesktop.org/series/59915/
> - https://patchwork.freedesktop.org/series/58665/
> - https://patchwork.freedesktop.org/series/59000/
> - https://patchwork.freedesktop.org/series/59002/
> - https://patchwork.freedesktop.org/series/59471/
>
> Changes since v1:
> - Adds patch denpendency in the comment
>
> Changes since v2:
> - Remove [RFC] from the subject
>
> Changes since v3:
> - Rebase the code
>
> Signed-off-by: Lowry Li (Arm Technology China) <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index e7cd690..9b87c25 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -303,6 +303,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
>
> drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
>
> + err = drm_plane_create_alpha_property(plane);
> + if (err)
> + goto cleanup;
> +
> + err = drm_plane_create_blend_mode_property(plane,
> + BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> + BIT(DRM_MODE_BLEND_PREMULTI) |
> + BIT(DRM_MODE_BLEND_COVERAGE));
> + if (err)
> + goto cleanup;
> +
> err = komeda_plane_create_layer_properties(kplane, layer);
> if (err)
> goto cleanup;
> --
> 1.9.1
>

lgtm.

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>