2018-04-12 14:41:58

by Lukasz Majewski

Subject: [PATCH] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>
---
.../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++
2 files changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+ lcd_panel: lcd-panel {
+ compatible = "koe,tx14d24vm1bpa";
+ backlight = <&backlight_lcd>;
+ power-supply = <&reg_3v3>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+Then one needs to extend the dispX node:
+
+ lcd_display: disp1 {
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 62314085b635..45e61af936e0 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1245,6 +1245,29 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};

+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+ .pixelclock = { 5580000, 5850000, 6200000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 30, 30, 30 },
+ .hback_porch = { 30, 30, 30 },
+ .hsync_len = { 1, 5, 17 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 6, 6, 6 },
+ .vback_porch = { 5, 5, 5 },
+ .vsync_len = { 1, 2, 11 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+ .timings = &koe_tx14d24vm1bpa_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 115,
+ .height = 86,
+ },
+};
+
static const struct display_timing kyo_tcg121xglp_timing = {
.pixelclock = { 52000000, 65000000, 71000000 },
.hactive = { 1024, 1024, 1024 },
@@ -2155,6 +2178,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+ .compatible = "koe,tx14d24vm1bpa",
+ .data = &koe_tx14d24vm1bpa,
+ }, {
.compatible = "kyo,tcg121xglp",
.data = &kyo_tcg121xglp,
}, {
--
2.11.0

2018-04-16 19:26:18

by Rob Herring (Arm)

Subject: Re: [PATCH] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
> This commit adds support for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> ---
> .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++
> 2 files changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Reviewed-by: Rob Herring <[email protected]>

2018-05-04 10:30:41

by Lukasz Majewski

Subject: Re: [PATCH] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Rob,

> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
> > This commit adds support for KOE's 5.7" display.
> >
> > Signed-off-by: Lukasz Majewski <[email protected]>
> > ---
> > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> > ++++++++++++++++++++++
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>
> Reviewed-by: Rob Herring <[email protected]>
>

Gentle ping on this - as I don't know if this patch been applied.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-09 15:45:05

by Lukasz Majewski

Subject: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>
---
.../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++
2 files changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+ lcd_panel: lcd-panel {
+ compatible = "koe,tx14d24vm1bpa";
+ backlight = <&backlight_lcd>;
+ power-supply = <&reg_3v3>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+Then one needs to extend the dispX node:
+
+ lcd_display: disp1 {
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index d9984bdb5bb5..103b43ce7dee 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};

+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+ .pixelclock = { 5580000, 5850000, 6200000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 30, 30, 30 },
+ .hback_porch = { 30, 30, 30 },
+ .hsync_len = { 1, 5, 17 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 6, 6, 6 },
+ .vback_porch = { 5, 5, 5 },
+ .vsync_len = { 1, 2, 11 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+ .timings = &koe_tx14d24vm1bpa_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 115,
+ .height = 86,
+ },
+};
+
static const struct display_timing koe_tx31d200vm0baa_timing = {
.pixelclock = { 39600000, 43200000, 48000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2204,6 +2227,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+ .compatible = "koe,tx14d24vm1bpa",
+ .data = &koe_tx14d24vm1bpa,
+ }, {
.compatible = "koe,tx31d200vm0baa",
.data = &koe_tx31d200vm0baa,
}, {
--
2.11.0

2018-05-10 14:25:10

by Rob Herring (Arm)

Subject: Re: [PATCH] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Fri, May 4, 2018 at 5:28 AM, Lukasz Majewski <[email protected]> wrote:
> Hi Rob,
>
>> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
>> > This commit adds support for KOE's 5.7" display.
>> >
>> > Signed-off-by: Lukasz Majewski <[email protected]>
>> > ---
>> > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
>> > ++++++++++++++++++++++
>> > drivers/gpu/drm/panel/panel-simple.c | 26
>> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
>> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>>
>> Reviewed-by: Rob Herring <[email protected]>
>>
>
> Gentle ping on this - as I don't know if this patch been applied.

This should go thru DRM tree via Thierry.

Rob

2018-05-10 14:26:26

by Rob Herring

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Wed, May 9, 2018 at 10:43 AM, Lukasz Majewski <[email protected]> wrote:
> This commit adds support for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>

Please add ack/reviewed-by's when posting new versions.

Rob

2018-05-11 15:05:14

by Lukasz Majewski

Subject: Re: [PATCH] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Rob, Thierry

> On Fri, May 4, 2018 at 5:28 AM, Lukasz Majewski <[email protected]> wrote:
> > Hi Rob,
> >
> >> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
> >> > This commit adds support for KOE's 5.7" display.
> >> >
> >> > Signed-off-by: Lukasz Majewski <[email protected]>
> >> > ---
> >> > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> >> > ++++++++++++++++++++++
> >> > drivers/gpu/drm/panel/panel-simple.c | 26
> >> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode
> >> > 100644
> >> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> >>
> >> Reviewed-by: Rob Herring <[email protected]>
> >>
> >
> > Gentle ping on this - as I don't know if this patch been applied.
>
> This should go thru DRM tree via Thierry.

Would it be possible to pull this patch along with:
[PATCH v3] display: panel: Add AUO g070vvn01 display support (800x480)

To your -next tree (as we are now with -rc4) ?

>
> Rob


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-19 11:07:15

by Lukasz Majewski

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> This commit adds support for KOE's 5.7" display.
>

Thierry, shall I perform some more work on this code, or is it
eligible for applying to your tree?

Best regards,
Łukasz

> Signed-off-by: Lukasz Majewski <[email protected]>
> ---
> .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> ++++++++++++++++++++++
> drivers/gpu/drm/panel/panel-simple.c | 26
> ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> 240) TFT LCD panel +
> +Required properties:
> +- compatible: should be "koe,tx14d24vm1bpa"
> +- backlight: phandle of the backlight device attached to the panel
> +- power-supply: single regulator to provide the supply voltage
> +
> +Required nodes:
> +- port: Parallel port mapping to connect this display
> +
> +This panel needs single power supply voltage. Its backlight is
> conntrolled +via PWM signal.
> +
> +Example:
> +--------
> +
> +Example device-tree definition when connected to iMX53 based board
> +
> + lcd_panel: lcd-panel {
> + compatible = "koe,tx14d24vm1bpa";
> + backlight = <&backlight_lcd>;
> + power-supply = <&reg_3v3>;
> +
> + port {
> + lcd_panel_in: endpoint {
> + remote-endpoint = <&lcd_display_out>;
> + };
> + };
> + };
> +
> +Then one needs to extend the dispX node:
> +
> + lcd_display: disp1 {
> +
> + port@1 {
> + reg = <1>;
> +
> + lcd_display_out: endpoint {
> + remote-endpoint = <&lcd_panel_in>;
> + };
> + };
> + };
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index
> d9984bdb5bb5..103b43ce7dee 100644 ---
> a/drivers/gpu/drm/panel/panel-simple.c +++
> b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static
> const struct panel_desc innolux_zj070na_01p = { },
> };
>
> +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> + .pixelclock = { 5580000, 5850000, 6200000 },
> + .hactive = { 320, 320, 320 },
> + .hfront_porch = { 30, 30, 30 },
> + .hback_porch = { 30, 30, 30 },
> + .hsync_len = { 1, 5, 17 },
> + .vactive = { 240, 240, 240 },
> + .vfront_porch = { 6, 6, 6 },
> + .vback_porch = { 5, 5, 5 },
> + .vsync_len = { 1, 2, 11 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc koe_tx14d24vm1bpa = {
> + .timings = &koe_tx14d24vm1bpa_timing,
> + .num_timings = 1,
> + .bpc = 6,
> + .size = {
> + .width = 115,
> + .height = 86,
> + },
> +};
> +
> static const struct display_timing koe_tx31d200vm0baa_timing = {
> .pixelclock = { 39600000, 43200000, 48000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -2204,6 +2227,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> .data = &innolux_zj070na_01p,
> }, {
> + .compatible = "koe,tx14d24vm1bpa",
> + .data = &koe_tx14d24vm1bpa,
> + }, {
> .compatible = "koe,tx31d200vm0baa",
> .data = &koe_tx31d200vm0baa,
> }, {


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-28 07:58:02

by Lukasz Majewski

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi,

> Hi Thierry,
>
> > This commit adds support for KOE's 5.7" display.
> >
>
> Thierry, shall I perform some more work on this code, or is it
> eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer
so he/she could apply this patch?

>
> Best regards,
> Łukasz
>
> > Signed-off-by: Lukasz Majewski <[email protected]>
> > ---
> > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> > ++++++++++++++++++++++
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> > 240) TFT LCD panel +
> > +Required properties:
> > +- compatible: should be "koe,tx14d24vm1bpa"
> > +- backlight: phandle of the backlight device attached to the panel
> > +- power-supply: single regulator to provide the supply voltage
> > +
> > +Required nodes:
> > +- port: Parallel port mapping to connect this display
> > +
> > +This panel needs single power supply voltage. Its backlight is
> > conntrolled +via PWM signal.
> > +
> > +Example:
> > +--------
> > +
> > +Example device-tree definition when connected to iMX53 based board
> > +
> > + lcd_panel: lcd-panel {
> > + compatible = "koe,tx14d24vm1bpa";
> > + backlight = <&backlight_lcd>;
> > + power-supply = <&reg_3v3>;
> > +
> > + port {
> > + lcd_panel_in: endpoint {
> > + remote-endpoint =
> > <&lcd_display_out>;
> > + };
> > + };
> > + };
> > +
> > +Then one needs to extend the dispX node:
> > +
> > + lcd_display: disp1 {
> > +
> > + port@1 {
> > + reg = <1>;
> > +
> > + lcd_display_out: endpoint {
> > + remote-endpoint = <&lcd_panel_in>;
> > + };
> > + };
> > + };
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c index
> > d9984bdb5bb5..103b43ce7dee 100644 ---
> > a/drivers/gpu/drm/panel/panel-simple.c +++
> > b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static
> > const struct panel_desc innolux_zj070na_01p = { },
> > };
> >
> > +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> > + .pixelclock = { 5580000, 5850000, 6200000 },
> > + .hactive = { 320, 320, 320 },
> > + .hfront_porch = { 30, 30, 30 },
> > + .hback_porch = { 30, 30, 30 },
> > + .hsync_len = { 1, 5, 17 },
> > + .vactive = { 240, 240, 240 },
> > + .vfront_porch = { 6, 6, 6 },
> > + .vback_porch = { 5, 5, 5 },
> > + .vsync_len = { 1, 2, 11 },
> > + .flags = DISPLAY_FLAGS_DE_HIGH,
> > +};
> > +
> > +static const struct panel_desc koe_tx14d24vm1bpa = {
> > + .timings = &koe_tx14d24vm1bpa_timing,
> > + .num_timings = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 115,
> > + .height = 86,
> > + },
> > +};
> > +
> > static const struct display_timing koe_tx31d200vm0baa_timing = {
> > .pixelclock = { 39600000, 43200000, 48000000 },
> > .hactive = { 1280, 1280, 1280 },
> > @@ -2204,6 +2227,9 @@ static const struct of_device_id
> > platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> > .data = &innolux_zj070na_01p,
> > }, {
> > + .compatible = "koe,tx14d24vm1bpa",
> > + .data = &koe_tx14d24vm1bpa,
> > + }, {
> > .compatible = "koe,tx31d200vm0baa",
> > .data = &koe_tx31d200vm0baa,
> > }, {
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-29 14:33:16

by Thierry Reding

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote:
> Hi,
>
> > Hi Thierry,
> >
> > > This commit adds support for KOE's 5.7" display.
> > >
> >
> > Thierry, shall I perform some more work on this code, or is it
> > eligible for applying to your tree?
>
> Gentle ping. If Thierry is overworked - maybe there is a co-maintainer
> so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the
chances of this being noticed.

This is also still missing a Reviewed-by or Acked-by from Rob.

Thierry

Attachments:

2018-05-29 15:04:07

by Lukasz Majewski

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote:
> > Hi,
> >
> > > Hi Thierry,
> > >
> > > > This commit adds support for KOE's 5.7" display.
> > > >
> > >
> > > Thierry, shall I perform some more work on this code, or is it
> > > eligible for applying to your tree?
> >
> > Gentle ping. If Thierry is overworked - maybe there is a
> > co-maintainer so he/she could apply this patch?
>
> Please use the proper prefix for the commit subject to increase the
> chances of this being noticed.

Ok. Is there any list of prefixes in the kernel repository, so I could
look for them (like get_prefix.py - similar to get_maintainer script)?

I've used "display: panel" prefix, but I should have used "drm/panel"

>
> This is also still missing a Reviewed-by or Acked-by from Rob.

Rob has already reviewed this patch. I will send v2
with Rob's Reviewed-by tag.

>
> Thierry




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-29 15:09:02

by Lukasz Majewski

Subject: [PATCH v2] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Changes for v2:
- Add Reviewed-by tag

---
.../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++
2 files changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+ lcd_panel: lcd-panel {
+ compatible = "koe,tx14d24vm1bpa";
+ backlight = <&backlight_lcd>;
+ power-supply = <&reg_3v3>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+Then one needs to extend the dispX node:
+
+ lcd_display: disp1 {
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index d9984bdb5bb5..103b43ce7dee 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};

+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+ .pixelclock = { 5580000, 5850000, 6200000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 30, 30, 30 },
+ .hback_porch = { 30, 30, 30 },
+ .hsync_len = { 1, 5, 17 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 6, 6, 6 },
+ .vback_porch = { 5, 5, 5 },
+ .vsync_len = { 1, 2, 11 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+ .timings = &koe_tx14d24vm1bpa_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 115,
+ .height = 86,
+ },
+};
+
static const struct display_timing koe_tx31d200vm0baa_timing = {
.pixelclock = { 39600000, 43200000, 48000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2204,6 +2227,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+ .compatible = "koe,tx14d24vm1bpa",
+ .data = &koe_tx14d24vm1bpa,
+ }, {
.compatible = "koe,tx31d200vm0baa",
.data = &koe_tx31d200vm0baa,
}, {
--
2.11.0

2018-05-29 15:23:47

by Thierry Reding

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote:
> Hi Thierry,
>
> > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote:
> > > Hi,
> > >
> > > > Hi Thierry,
> > > >
> > > > > This commit adds support for KOE's 5.7" display.
> > > > >
> > > >
> > > > Thierry, shall I perform some more work on this code, or is it
> > > > eligible for applying to your tree?
> > >
> > > Gentle ping. If Thierry is overworked - maybe there is a
> > > co-maintainer so he/she could apply this patch?
> >
> > Please use the proper prefix for the commit subject to increase the
> > chances of this being noticed.
>
> Ok. Is there any list of prefixes in the kernel repository, so I could
> look for them (like get_prefix.py - similar to get_maintainer script)?

I don't think there is. A good rule of thumb that I use is to go over
the git log for the last couple of commits and see if there's a clear
pattern. This doesn't work for every subsystem, but drm/panel is very
consistent in this regard, on purpose.

> I've used "display: panel" prefix, but I should have used "drm/panel"
>
> >
> > This is also still missing a Reviewed-by or Acked-by from Rob.
>
> Rob has already reviewed this patch. I will send v2
> with Rob's Reviewed-by tag.

Okay, I'll apply that v2 then.

Thanks,
Thierry

Attachments:

2018-05-29 15:35:54

by Lukasz Majewski

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote:
> > Hi Thierry,
> >
> > > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote:
> > > > Hi,
> > > >
> > > > > Hi Thierry,
> > > > >
> > > > > > This commit adds support for KOE's 5.7" display.
> > > > > >
> > > > >
> > > > > Thierry, shall I perform some more work on this code, or is it
> > > > > eligible for applying to your tree?
> > > >
> > > > Gentle ping. If Thierry is overworked - maybe there is a
> > > > co-maintainer so he/she could apply this patch?
> > >
> > > Please use the proper prefix for the commit subject to increase
> > > the chances of this being noticed.
> >
> > Ok. Is there any list of prefixes in the kernel repository, so I
> > could look for them (like get_prefix.py - similar to get_maintainer
> > script)?
>
> I don't think there is. A good rule of thumb that I use is to go over
> the git log for the last couple of commits and see if there's a clear
> pattern. This doesn't work for every subsystem, but drm/panel is very
> consistent in this regard, on purpose.

I see.

Is the DRM/panel tree hosted on git.kernel.org?

The tree maintained by you there seems to be:
kernel/git/thierry.reding/linux-pwm.git

IIRC it is hosted elsewhere. Am I right?

>
> > I've used "display: panel" prefix, but I should have used
> > "drm/panel"
> > >
> > > This is also still missing a Reviewed-by or Acked-by from Rob.
> >
> > Rob has already reviewed this patch. I will send v2
> > with Rob's Reviewed-by tag.
>
> Okay, I'll apply that v2 then.

Thanks.

>
> Thanks,
> Thierry




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-05-29 16:14:40

by Thierry Reding

Subject: Re: [PATCH RESEND] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

On Tue, May 29, 2018 at 05:33:38PM +0200, Lukasz Majewski wrote:
> Hi Thierry,
>
> > On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote:
> > > Hi Thierry,
> > >
> > > > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote:
> > > > > Hi,
> > > > >
> > > > > > Hi Thierry,
> > > > > >
> > > > > > > This commit adds support for KOE's 5.7" display.
> > > > > > >
> > > > > >
> > > > > > Thierry, shall I perform some more work on this code, or is it
> > > > > > eligible for applying to your tree?
> > > > >
> > > > > Gentle ping. If Thierry is overworked - maybe there is a
> > > > > co-maintainer so he/she could apply this patch?
> > > >
> > > > Please use the proper prefix for the commit subject to increase
> > > > the chances of this being noticed.
> > >
> > > Ok. Is there any list of prefixes in the kernel repository, so I
> > > could look for them (like get_prefix.py - similar to get_maintainer
> > > script)?
> >
> > I don't think there is. A good rule of thumb that I use is to go over
> > the git log for the last couple of commits and see if there's a clear
> > pattern. This doesn't work for every subsystem, but drm/panel is very
> > consistent in this regard, on purpose.
>
> I see.
>
> Is the DRM/panel tree hosted on git.kernel.org?
>
> The tree maintained by you there seems to be:
> kernel/git/thierry.reding/linux-pwm.git
>
> IIRC it is hosted elsewhere. Am I right?

drm/panel is part of drm-misc:

https://cgit.freedesktop.org/drm/drm-misc/

Thierry

Attachments:

2018-06-22 08:57:20

by Lukasz Majewski

Subject: Re: [PATCH v2] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> This commit adds support for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> Changes for v2:
> - Add Reviewed-by tag

Could you apply this patch to your tree?

Thanks in advance,
Łukasz

>
> ---
> .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> ++++++++++++++++++++++
> drivers/gpu/drm/panel/panel-simple.c | 26
> ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> 240) TFT LCD panel +
> +Required properties:
> +- compatible: should be "koe,tx14d24vm1bpa"
> +- backlight: phandle of the backlight device attached to the panel
> +- power-supply: single regulator to provide the supply voltage
> +
> +Required nodes:
> +- port: Parallel port mapping to connect this display
> +
> +This panel needs single power supply voltage. Its backlight is
> conntrolled +via PWM signal.
> +
> +Example:
> +--------
> +
> +Example device-tree definition when connected to iMX53 based board
> +
> + lcd_panel: lcd-panel {
> + compatible = "koe,tx14d24vm1bpa";
> + backlight = <&backlight_lcd>;
> + power-supply = <&reg_3v3>;
> +
> + port {
> + lcd_panel_in: endpoint {
> + remote-endpoint = <&lcd_display_out>;
> + };
> + };
> + };
> +
> +Then one needs to extend the dispX node:
> +
> + lcd_display: disp1 {
> +
> + port@1 {
> + reg = <1>;
> +
> + lcd_display_out: endpoint {
> + remote-endpoint = <&lcd_panel_in>;
> + };
> + };
> + };
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index
> d9984bdb5bb5..103b43ce7dee 100644 ---
> a/drivers/gpu/drm/panel/panel-simple.c +++
> b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static
> const struct panel_desc innolux_zj070na_01p = { },
> };
>
> +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> + .pixelclock = { 5580000, 5850000, 6200000 },
> + .hactive = { 320, 320, 320 },
> + .hfront_porch = { 30, 30, 30 },
> + .hback_porch = { 30, 30, 30 },
> + .hsync_len = { 1, 5, 17 },
> + .vactive = { 240, 240, 240 },
> + .vfront_porch = { 6, 6, 6 },
> + .vback_porch = { 5, 5, 5 },
> + .vsync_len = { 1, 2, 11 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc koe_tx14d24vm1bpa = {
> + .timings = &koe_tx14d24vm1bpa_timing,
> + .num_timings = 1,
> + .bpc = 6,
> + .size = {
> + .width = 115,
> + .height = 86,
> + },
> +};
> +
> static const struct display_timing koe_tx31d200vm0baa_timing = {
> .pixelclock = { 39600000, 43200000, 48000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -2204,6 +2227,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> .data = &innolux_zj070na_01p,
> }, {
> + .compatible = "koe,tx14d24vm1bpa",
> + .data = &koe_tx14d24vm1bpa,
> + }, {
> .compatible = "koe,tx31d200vm0baa",
> .data = &koe_tx31d200vm0baa,
> }, {




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-06-29 17:37:44

by Lukasz Majewski

Subject: Re: [PATCH v2] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> Hi Thierry,
>
> > This commit adds support for KOE's 5.7" display.
> >
> > Signed-off-by: Lukasz Majewski <[email protected]>
> > Reviewed-by: Rob Herring <[email protected]>
> > ---
> > Changes for v2:
> > - Add Reviewed-by tag
>
> Could you apply this patch to your tree?

If I may gentle ping on this patch..... It is quite mature now... :-)

Best regards,
Łukasz

>
> Thanks in advance,
> Łukasz
>
> >
> > ---
> > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> > ++++++++++++++++++++++
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> > 240) TFT LCD panel +
> > +Required properties:
> > +- compatible: should be "koe,tx14d24vm1bpa"
> > +- backlight: phandle of the backlight device attached to the panel
> > +- power-supply: single regulator to provide the supply voltage
> > +
> > +Required nodes:
> > +- port: Parallel port mapping to connect this display
> > +
> > +This panel needs single power supply voltage. Its backlight is
> > conntrolled +via PWM signal.
> > +
> > +Example:
> > +--------
> > +
> > +Example device-tree definition when connected to iMX53 based board
> > +
> > + lcd_panel: lcd-panel {
> > + compatible = "koe,tx14d24vm1bpa";
> > + backlight = <&backlight_lcd>;
> > + power-supply = <&reg_3v3>;
> > +
> > + port {
> > + lcd_panel_in: endpoint {
> > + remote-endpoint =
> > <&lcd_display_out>;
> > + };
> > + };
> > + };
> > +
> > +Then one needs to extend the dispX node:
> > +
> > + lcd_display: disp1 {
> > +
> > + port@1 {
> > + reg = <1>;
> > +
> > + lcd_display_out: endpoint {
> > + remote-endpoint = <&lcd_panel_in>;
> > + };
> > + };
> > + };
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c index
> > d9984bdb5bb5..103b43ce7dee 100644 ---
> > a/drivers/gpu/drm/panel/panel-simple.c +++
> > b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static
> > const struct panel_desc innolux_zj070na_01p = { },
> > };
> >
> > +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> > + .pixelclock = { 5580000, 5850000, 6200000 },
> > + .hactive = { 320, 320, 320 },
> > + .hfront_porch = { 30, 30, 30 },
> > + .hback_porch = { 30, 30, 30 },
> > + .hsync_len = { 1, 5, 17 },
> > + .vactive = { 240, 240, 240 },
> > + .vfront_porch = { 6, 6, 6 },
> > + .vback_porch = { 5, 5, 5 },
> > + .vsync_len = { 1, 2, 11 },
> > + .flags = DISPLAY_FLAGS_DE_HIGH,
> > +};
> > +
> > +static const struct panel_desc koe_tx14d24vm1bpa = {
> > + .timings = &koe_tx14d24vm1bpa_timing,
> > + .num_timings = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 115,
> > + .height = 86,
> > + },
> > +};
> > +
> > static const struct display_timing koe_tx31d200vm0baa_timing = {
> > .pixelclock = { 39600000, 43200000, 48000000 },
> > .hactive = { 1280, 1280, 1280 },
> > @@ -2204,6 +2227,9 @@ static const struct of_device_id
> > platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> > .data = &innolux_zj070na_01p,
> > }, {
> > + .compatible = "koe,tx14d24vm1bpa",
> > + .data = &koe_tx14d24vm1bpa,
> > + }, {
> > .compatible = "koe,tx31d200vm0baa",
> > .data = &koe_tx31d200vm0baa,
> > }, {
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2018-07-08 08:44:57

by Lukasz Majewski

Subject: Re: [PATCH v2] display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Hi Thierry,

> Hi Thierry,
>
> > Hi Thierry,
> >
> > > This commit adds support for KOE's 5.7" display.
> > >
> > > Signed-off-by: Lukasz Majewski <[email protected]>
> > > Reviewed-by: Rob Herring <[email protected]>
> > > ---
> > > Changes for v2:
> > > - Add Reviewed-by tag
> >
> > Could you apply this patch to your tree?
>
> If I may gentle ping on this patch..... It is quite mature now... :-)

If I may gentle ping on this patch...

Thanks in advance,
Łukasz Majewski

>
> Best regards,
> Łukasz
>
> >
> > Thanks in advance,
> > Łukasz
> >
> > >
> > > ---
> > > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> > > ++++++++++++++++++++++
> > > drivers/gpu/drm/panel/panel-simple.c | 26
> > > ++++++++++++++ 2 files changed, 68 insertions(+) create mode
> > > 100644
> > > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > > new file mode 100644 index 000000000000..be7ac666807b
> > > --- /dev/null +++
> > > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> > > @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> > > 240) TFT LCD panel +
> > > +Required properties:
> > > +- compatible: should be "koe,tx14d24vm1bpa"
> > > +- backlight: phandle of the backlight device attached to the
> > > panel +- power-supply: single regulator to provide the supply
> > > voltage +
> > > +Required nodes:
> > > +- port: Parallel port mapping to connect this display
> > > +
> > > +This panel needs single power supply voltage. Its backlight is
> > > conntrolled +via PWM signal.
> > > +
> > > +Example:
> > > +--------
> > > +
> > > +Example device-tree definition when connected to iMX53 based
> > > board +
> > > + lcd_panel: lcd-panel {
> > > + compatible = "koe,tx14d24vm1bpa";
> > > + backlight = <&backlight_lcd>;
> > > + power-supply = <&reg_3v3>;
> > > +
> > > + port {
> > > + lcd_panel_in: endpoint {
> > > + remote-endpoint =
> > > <&lcd_display_out>;
> > > + };
> > > + };
> > > + };
> > > +
> > > +Then one needs to extend the dispX node:
> > > +
> > > + lcd_display: disp1 {
> > > +
> > > + port@1 {
> > > + reg = <1>;
> > > +
> > > + lcd_display_out: endpoint {
> > > + remote-endpoint =
> > > <&lcd_panel_in>;
> > > + };
> > > + };
> > > + };
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c index
> > > d9984bdb5bb5..103b43ce7dee 100644 ---
> > > a/drivers/gpu/drm/panel/panel-simple.c +++
> > > b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@
> > > static const struct panel_desc innolux_zj070na_01p = { },
> > > };
> > >
> > > +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> > > + .pixelclock = { 5580000, 5850000, 6200000 },
> > > + .hactive = { 320, 320, 320 },
> > > + .hfront_porch = { 30, 30, 30 },
> > > + .hback_porch = { 30, 30, 30 },
> > > + .hsync_len = { 1, 5, 17 },
> > > + .vactive = { 240, 240, 240 },
> > > + .vfront_porch = { 6, 6, 6 },
> > > + .vback_porch = { 5, 5, 5 },
> > > + .vsync_len = { 1, 2, 11 },
> > > + .flags = DISPLAY_FLAGS_DE_HIGH,
> > > +};
> > > +
> > > +static const struct panel_desc koe_tx14d24vm1bpa = {
> > > + .timings = &koe_tx14d24vm1bpa_timing,
> > > + .num_timings = 1,
> > > + .bpc = 6,
> > > + .size = {
> > > + .width = 115,
> > > + .height = 86,
> > > + },
> > > +};
> > > +
> > > static const struct display_timing koe_tx31d200vm0baa_timing = {
> > > .pixelclock = { 39600000, 43200000, 48000000 },
> > > .hactive = { 1280, 1280, 1280 },
> > > @@ -2204,6 +2227,9 @@ static const struct of_device_id
> > > platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> > > .data = &innolux_zj070na_01p,
> > > }, {
> > > + .compatible = "koe,tx14d24vm1bpa",
> > > + .data = &koe_tx14d24vm1bpa,
> > > + }, {
> > > .compatible = "koe,tx31d200vm0baa",
> > > .data = &koe_tx31d200vm0baa,
> > > }, {
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> > [email protected]
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2019-04-04 11:24:08

by Lukasz Majewski

Subject: [PATCH v3 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

It must have been lost during the development process, so
I do resend it now.

Changes for v3 :
- Rebase this patch on top of newest kernel (5.1-rc3):
SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
- Split this patch to have separate Documentation entry
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9e8218f6a3f2..196c6adf8168 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1549,6 +1549,29 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};

+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+ .pixelclock = { 5580000, 5850000, 6200000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 30, 30, 30 },
+ .hback_porch = { 30, 30, 30 },
+ .hsync_len = { 1, 5, 17 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 6, 6, 6 },
+ .vback_porch = { 5, 5, 5 },
+ .vsync_len = { 1, 2, 11 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+ .timings = &koe_tx14d24vm1bpa_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 115,
+ .height = 86,
+ },
+};
+
static const struct display_timing koe_tx31d200vm0baa_timing = {
.pixelclock = { 39600000, 43200000, 48000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2680,6 +2703,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+ .compatible = "koe,tx14d24vm1bpa",
+ .data = &koe_tx14d24vm1bpa,
+ }, {
.compatible = "koe,tx31d200vm0baa",
.data = &koe_tx31d200vm0baa,
}, {
--
2.11.0

2019-04-04 11:25:31

by Lukasz Majewski

Subject: [PATCH v3 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

This commit adds documentation entry description for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v3 :
- New patch
---
.../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+ lcd_panel: lcd-panel {
+ compatible = "koe,tx14d24vm1bpa";
+ backlight = <&backlight_lcd>;
+ power-supply = <&reg_3v3>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+Then one needs to extend the dispX node:
+
+ lcd_display: disp1 {
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
--
2.11.0

2019-04-26 12:30:34

by Lukasz Majewski

Subject: Re: [PATCH v3 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

Dear All,

> This commit adds documentation entry description for KOE's 5.7"
> display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
>
> ---
> Previous discussion (and Rob's Reviewed-by) about this patch
> https://patchwork.kernel.org/patch/10339595/
>
> Changes for v3 :
> - New patch

Gentle ping on this patch...

> ---
> .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42
> ++++++++++++++++++++++ 1 file changed, 42 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
> @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x
> 240) TFT LCD panel +
> +Required properties:
> +- compatible: should be "koe,tx14d24vm1bpa"
> +- backlight: phandle of the backlight device attached to the panel
> +- power-supply: single regulator to provide the supply voltage
> +
> +Required nodes:
> +- port: Parallel port mapping to connect this display
> +
> +This panel needs single power supply voltage. Its backlight is
> conntrolled +via PWM signal.
> +
> +Example:
> +--------
> +
> +Example device-tree definition when connected to iMX53 based board
> +
> + lcd_panel: lcd-panel {
> + compatible = "koe,tx14d24vm1bpa";
> + backlight = <&backlight_lcd>;
> + power-supply = <&reg_3v3>;
> +
> + port {
> + lcd_panel_in: endpoint {
> + remote-endpoint = <&lcd_display_out>;
> + };
> + };
> + };
> +
> +Then one needs to extend the dispX node:
> +
> + lcd_display: disp1 {
> +
> + port@1 {
> + reg = <1>;
> +
> + lcd_display_out: endpoint {
> + remote-endpoint = <&lcd_panel_in>;
> + };
> + };
> + };




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2019-04-26 12:31:12

by Lukasz Majewski

Subject: Re: [PATCH v3 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

Dear All,

> This commit adds support for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
>
> ---
> Previous discussion (and Rob's Reviewed-by) about this patch
> https://patchwork.kernel.org/patch/10339595/
>
> It must have been lost during the development process, so
> I do resend it now.
>
> Changes for v3 :
> - Rebase this patch on top of newest kernel (5.1-rc3):
> SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
> - Split this patch to have separate Documentation entry

Gentle ping on this patch...

> ---
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index
> 9e8218f6a3f2..196c6adf8168 100644 ---
> a/drivers/gpu/drm/panel/panel-simple.c +++
> b/drivers/gpu/drm/panel/panel-simple.c @@ -1549,6 +1549,29 @@ static
> const struct panel_desc innolux_zj070na_01p = { },
> };
>
> +static const struct display_timing koe_tx14d24vm1bpa_timing = {
> + .pixelclock = { 5580000, 5850000, 6200000 },
> + .hactive = { 320, 320, 320 },
> + .hfront_porch = { 30, 30, 30 },
> + .hback_porch = { 30, 30, 30 },
> + .hsync_len = { 1, 5, 17 },
> + .vactive = { 240, 240, 240 },
> + .vfront_porch = { 6, 6, 6 },
> + .vback_porch = { 5, 5, 5 },
> + .vsync_len = { 1, 2, 11 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc koe_tx14d24vm1bpa = {
> + .timings = &koe_tx14d24vm1bpa_timing,
> + .num_timings = 1,
> + .bpc = 6,
> + .size = {
> + .width = 115,
> + .height = 86,
> + },
> +};
> +
> static const struct display_timing koe_tx31d200vm0baa_timing = {
> .pixelclock = { 39600000, 43200000, 48000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -2680,6 +2703,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "innolux,zj070na-01p",
> .data = &innolux_zj070na_01p,
> }, {
> + .compatible = "koe,tx14d24vm1bpa",
> + .data = &koe_tx14d24vm1bpa,
> + }, {
> .compatible = "koe,tx31d200vm0baa",
> .data = &koe_tx31d200vm0baa,
> }, {




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]

Attachments:

2019-05-15 16:06:51

by Lukasz Majewski

Subject: [PATCH v4 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

This commit adds documentation entry description for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v4:
- Rebase on top of newest mainline
SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7

Changes for v3 :
- New patch
---
.../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+ lcd_panel: lcd-panel {
+ compatible = "koe,tx14d24vm1bpa";
+ backlight = <&backlight_lcd>;
+ power-supply = <&reg_3v3>;
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+Then one needs to extend the dispX node:
+
+ lcd_display: disp1 {
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
--
2.11.0

2019-05-15 16:08:38

by Lukasz Majewski

Subject: [PATCH v4 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

It must have been lost during the development process, so
I do resend it now.

Changes for v4:
- Rebase on top of newest mainline (no functional changes)
SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7

Changes for v3 :
- Rebase this patch on top of newest kernel (5.1-rc3):
SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
- Split this patch to have separate Documentation entry
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 569be4efd8d1..c3e5900b04fa 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1549,6 +1549,29 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};

+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+ .pixelclock = { 5580000, 5850000, 6200000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 30, 30, 30 },
+ .hback_porch = { 30, 30, 30 },
+ .hsync_len = { 1, 5, 17 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 6, 6, 6 },
+ .vback_porch = { 5, 5, 5 },
+ .vsync_len = { 1, 2, 11 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+ .timings = &koe_tx14d24vm1bpa_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 115,
+ .height = 86,
+ },
+};
+
static const struct display_timing koe_tx31d200vm0baa_timing = {
.pixelclock = { 39600000, 43200000, 48000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2706,6 +2729,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+ .compatible = "koe,tx14d24vm1bpa",
+ .data = &koe_tx14d24vm1bpa,
+ }, {
.compatible = "koe,tx31d200vm0baa",
.data = &koe_tx31d200vm0baa,
}, {
--
2.11.0

2019-05-24 21:59:15

by Rob Herring (Arm)

Subject: Re: [PATCH v4 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

On Wed, 15 May 2019 18:04:28 +0200, Lukasz Majewski wrote:
> This commit adds documentation entry description for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
>
> ---
> Previous discussion (and Rob's Reviewed-by) about this patch
> https://patchwork.kernel.org/patch/10339595/
>
> Changes for v4:
> - Rebase on top of newest mainline
> SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7
>
> Changes for v3 :
> - New patch
> ---
> .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>

Reviewed-by: Rob Herring <[email protected]>

2019-05-25 06:57:07

by Sam Ravnborg

Subject: Re: [PATCH v4 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

On Wed, May 15, 2019 at 06:04:28PM +0200, Lukasz Majewski wrote:
> This commit adds documentation entry description for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>

Thanks, applied

Sam

2019-05-25 06:58:49

by Sam Ravnborg

Subject: Re: [PATCH v4 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

On Wed, May 15, 2019 at 06:06:12PM +0200, Lukasz Majewski wrote:
> This commit adds support for KOE's 5.7" display.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>

Thanks, applied.

Sam