2019-05-27 15:39:15

by Yue Haibing

Subject: [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy:
drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used [-Wunused-but-set-variable]

It's never used since introduction in commit 29de76240e86 ("fpga:
dfl: fme: add partial reconfiguration sub feature support")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/fpga/dfl-fme-main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
index 086ad2420ade..cb7c4e258298 100644
--- a/drivers/fpga/dfl-fme-main.c
+++ b/drivers/fpga/dfl-fme-main.c
@@ -213,10 +213,8 @@ static int fme_dev_init(struct platform_device *pdev)
static void fme_dev_destroy(struct platform_device *pdev)
{
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
- struct dfl_fme *fme;

mutex_lock(&pdata->lock);
- fme = dfl_fpga_pdata_get_private(pdata);
dfl_fpga_pdata_set_private(pdata, NULL);
mutex_unlock(&pdata->lock);
}
--
2.17.1

2019-05-27 22:11:55

by Ben Widawsky

Subject: Re: [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'

On 19-05-27 23:34:24, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy:
> drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in commit 29de76240e86 ("fpga:
> dfl: fme: add partial reconfiguration sub feature support")
>
> Signed-off-by: YueHaibing <[email protected]>
Acked-by: Ben Widawsky <[email protected]>

[snip]