2019-05-27 12:44:11

by Maxime Chevallier

Subject: [PATCH net-next] net: mvpp2: cls: Check RSS table index validity when creating a context

Make sure we don't use an out-of-bound index for the per-port RSS
context array.

As of today, the global context creation in mvpp22_rss_context_create
will prevent us from reaching this case, but we should still make sure
we are using a sane value anyway.

Reported-by: kbuild test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Maxime Chevallier <[email protected]>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index cd0daad011ce..bd19a910dc90 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -1466,6 +1466,9 @@ int mvpp22_port_rss_ctx_create(struct mvpp2_port *port, u32 *port_ctx)
break;
}

+ if (i == MVPP22_N_RSS_TABLES)
+ return -EINVAL;
+
port->rss_ctx[i] = rss_ctx;
*port_ctx = i;

--
2.20.1

2019-05-28 18:21:52

by David Miller

Subject: Re: [PATCH net-next] net: mvpp2: cls: Check RSS table index validity when creating a context

From: Maxime Chevallier <[email protected]>
Date: Mon, 27 May 2019 13:52:01 +0200

> Make sure we don't use an out-of-bound index for the per-port RSS
> context array.
>
> As of today, the global context creation in mvpp22_rss_context_create
> will prevent us from reaching this case, but we should still make sure
> we are using a sane value anyway.
>
> Reported-by: kbuild test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Maxime Chevallier <[email protected]>

Applied.