This patch series brings together patches [1] and [2] which
introduce mclk0 clock source via DT.
mclk0..3 are the four clock sources options
of SAI's clock MUX.
mclk0 option selects:
- Bus Clock on i.MX8
- MCLK1 on i.MX6/7
Finally we also update the DT binding information for SAI clocks.
In [1] and [2] Nicolin had a very good point on the fact that
mclk0 might not be needed in the DT. Anyhow, there are two reasons
for which I think mlck0 should be added to DT:
1) SAI clock source select MUX is really part of the hardware
2) flexibility! We let DT tell us which is the option for MUX
option 0.
[1] lkml.org/lkml/2019/4/20/141
[2] lkml.org/lkml/2019/4/20/56
Daniel Baluta (2):
dt-bindings: sound: Clarify the usage of clocks in SAI
ASoC: fsl_sai: Read SAI clock source 0 from DT
Shengjiu Wang (1):
ARM: dts: imx: Add mclk0 clock for SAI
Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++--
arch/arm/boot/dts/imx6sx.dtsi | 6 ++++--
arch/arm/boot/dts/imx6ul.dtsi | 9 ++++++---
arch/arm/boot/dts/imx7s.dtsi | 9 ++++++---
sound/soc/fsl/fsl_sai.c | 3 +--
5 files changed, 20 insertions(+), 12 deletions(-)
--
2.17.1
On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote:
> 1) SAI clock source select MUX is really part of the hardware
> 2) flexibility! We let DT tell us which is the option for MUX
> option 0.
I think the "MUX" is plausible comparing to your previous version.
As long as DT maintainers ack the DT binding doc, I would be okay
to ack too. Just one comments at the dts/dtsi changes, I know the
driver would just warn old DTs, but it does change the behavior at
the mclk_clk[0] from previously bus_clk to NULL after this series.
On Wed, 2019-05-29 at 16:03 -0700, Nicolin Chen wrote:
> On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote:
>
> > 1) SAI clock source select MUX is really part of the hardware
> > 2) flexibility! We let DT tell us which is the option for MUX
> > option 0.
>
> I think the "MUX" is plausible comparing to your previous version.
> As long as DT maintainers ack the DT binding doc, I would be okay
> to ack too. Just one comments at the dts/dtsi changes, I know the
> driver would just warn old DTs, but it does change the behavior at
> the mclk_clk[0] from previously bus_clk to NULL after this series.
Thanks for review, will fix in v2.