2019-05-28 17:41:37

by Vladimir Davydov

[permalink] [raw]
Subject: Re: [PATCH v5 7/7] mm: fix /proc/kpagecgroup interface for slab pages

On Tue, May 21, 2019 at 01:07:35PM -0700, Roman Gushchin wrote:
> Switching to an indirect scheme of getting mem_cgroup pointer for
> !root slab pages broke /proc/kpagecgroup interface for them.
>
> Let's fix it by learning page_cgroup_ino() how to get memcg
> pointer for slab pages.
>
> Reported-by: Shakeel Butt <[email protected]>
> Signed-off-by: Roman Gushchin <[email protected]>
> Reviewed-by: Shakeel Butt <[email protected]>
> ---
> mm/memcontrol.c | 5 ++++-
> mm/slab.h | 25 +++++++++++++++++++++++++
> mm/slab_common.c | 1 +
> 3 files changed, 30 insertions(+), 1 deletion(-)

What about mem_cgroup_from_kmem, see mm/list_lru.c?
Shouldn't we fix it, too?