2019-05-29 15:03:35

by Yue Haibing

Subject: [PATCH -next] eeprom: at24: Remove set but not used variable 'addr'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/misc/eeprom/at24.c: In function at24_make_dummy_client:
drivers/misc/eeprom/at24.c:514:21: warning: variable addr set but not used [-Wunused-but-set-variable]

It's not used since commit e7308628d0ae ("eeprom:
at24: use devm_i2c_new_dummy_device()")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/misc/eeprom/at24.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index ba8e73812644..fa730bb342e8 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -511,13 +511,11 @@ static int at24_make_dummy_client(struct at24_data *at24, unsigned int index,
struct regmap_config *regmap_config)
{
struct i2c_client *base_client, *dummy_client;
- unsigned short int addr;
struct regmap *regmap;
struct device *dev;

base_client = at24->client[0].client;
dev = &base_client->dev;
- addr = base_client->addr + index;

dummy_client = devm_i2c_new_dummy_device(dev, base_client->adapter,
base_client->addr + index);
--
2.17.1

2019-05-31 07:12:52

by Bartosz Golaszewski

Subject: Re: [PATCH -next] eeprom: at24: Remove set but not used variable 'addr'

śr., 29 maj 2019 o 17:00 YueHaibing <[email protected]> napisał(a):
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/misc/eeprom/at24.c: In function at24_make_dummy_client:
> drivers/misc/eeprom/at24.c:514:21: warning: variable addr set but not used [-Wunused-but-set-variable]
>
> It's not used since commit e7308628d0ae ("eeprom:
> at24: use devm_i2c_new_dummy_device()")
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/misc/eeprom/at24.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index ba8e73812644..fa730bb342e8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -511,13 +511,11 @@ static int at24_make_dummy_client(struct at24_data *at24, unsigned int index,
> struct regmap_config *regmap_config)
> {
> struct i2c_client *base_client, *dummy_client;
> - unsigned short int addr;
> struct regmap *regmap;
> struct device *dev;
>
> base_client = at24->client[0].client;
> dev = &base_client->dev;
> - addr = base_client->addr + index;
>
> dummy_client = devm_i2c_new_dummy_device(dev, base_client->adapter,
> base_client->addr + index);
> --
> 2.17.1
>
>

Applied, thanks!

Bart