2019-05-23 21:20:18

by Alan Mikhak

Subject: [PATCH v2 0/2] tools: PCI: Fix broken pcitest compilation

This patchset fixes a compiler error and two warnings that resulted in a
broken compilation of pcitest.

tools/pci/pcitest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--
2.7.4

2019-05-23 21:20:51

by Alan Mikhak

Subject: [PATCH v2 1/2] tools: PCI: Fix broken pcitest compilation

pcitest is currently broken due to the following compiler error
and related warning. Fix by changing the run_test() function
signature to return an integer result.

pcitest.c: In function run_test:
pcitest.c:143:9: warning: return with a value, in function
returning void
return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */

pcitest.c: In function main:
pcitest.c:232:9: error: void value not ignored as it ought to be
return run_test(test);

Signed-off-by: Alan Mikhak <[email protected]>
Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
Reviewed-by: Paul Walmsley <[email protected]>
---
tools/pci/pcitest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 5fa5c2bdd427..6dce894667f6 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -47,15 +47,15 @@ struct pci_test {
unsigned long size;
};

-static void run_test(struct pci_test *test)
+static int run_test(struct pci_test *test)
{
- long ret;
+ int ret = -EINVAL;
int fd;

fd = open(test->device, O_RDWR);
if (fd < 0) {
perror("can't open PCI Endpoint Test device");
- return;
+ return -ENODEV;
}

if (test->barnum >= 0 && test->barnum <= 5) {
--
2.7.4

2019-05-23 21:22:33

by Alan Mikhak

Subject: [PATCH v2 2/2] tools: PCI: Fix compiler warning in pcitest

Fix the following compiler warning in pcitest:

pcitest.c: In function main:
pcitest.c:214:4: warning: too many arguments for
format [-Wformat-extra-args]
"usage: %s [options]\n"

Signed-off-by: Alan Mikhak <[email protected]>
Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Reviewed-by: Paul Walmsley <[email protected]>
---
tools/pci/pcitest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 6dce894667f6..6f1303104d84 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -223,7 +223,7 @@ int main(int argc, char **argv)
"\t-r Read buffer test\n"
"\t-w Write buffer test\n"
"\t-c Copy buffer test\n"
- "\t-s <size> Size of buffer {default: 100KB}\n",
+ "\t-s <size> Size of buffer {default: 100KB}\n"
"\t-h Print this help message\n",
argv[0]);
return -EINVAL;
--
2.7.4

2019-05-29 17:00:52

by Lorenzo Pieralisi

Subject: Re: [PATCH v2 0/2] tools: PCI: Fix broken pcitest compilation

On Thu, May 23, 2019 at 02:17:59PM -0700, Alan Mikhak wrote:
> This patchset fixes a compiler error and two warnings that resulted in a
> broken compilation of pcitest.
>
> tools/pci/pcitest.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Applied to pci/misc for v5.3, thanks.

Lorenzo