2019-05-30 12:45:13

by Bhardwaj, Rajneesh

Subject: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family

Add the CPUID model number of Icelake Neural Network Processor for Deep
Learning Inference (ICL-NNPI) to the Intel family list. Icelake NNPI uses
model number 0x9D and this will be documented in a future version of Intel
Software Development Manual.

Cc: Borislav Petkov <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Kan Liang <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: [email protected]
Cc: Qiuxu Zhuo <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: x86-ml <[email protected]>
Cc: Linux PM <[email protected]>
Signed-off-by: Rajneesh Bhardwaj <[email protected]>
---
arch/x86/include/asm/intel-family.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
index 9f15384c504a..087de5d3b93a 100644
--- a/arch/x86/include/asm/intel-family.h
+++ b/arch/x86/include/asm/intel-family.h
@@ -53,6 +53,7 @@
#define INTEL_FAM6_CANNONLAKE_MOBILE 0x66

#define INTEL_FAM6_ICELAKE_MOBILE 0x7E
+#define INTEL_FAM6_ICELAKE_NNPI 0x9D

/* "Small Core" Processors (Atom) */

--
2.17.1

2019-06-04 16:11:30

by Andy Shevchenko

Subject: Re: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family

On Thu, May 30, 2019 at 06:08:27PM +0530, Rajneesh Bhardwaj wrote:
> Add the CPUID model number of Icelake Neural Network Processor for Deep

I believe we spell "Ice Lake".

> Learning Inference (ICL-NNPI) to the Intel family list. Icelake NNPI uses

Ditto.

> model number 0x9D and this will be documented in a future version of Intel
> Software Development Manual.
>
> Cc: Borislav Petkov <[email protected]>
> Cc: Dave Hansen <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: "H. Peter Anvin" <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Kan Liang <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: [email protected]
> Cc: Qiuxu Zhuo <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: x86-ml <[email protected]>
> Cc: Linux PM <[email protected]>
> Signed-off-by: Rajneesh Bhardwaj <[email protected]>
> ---
> arch/x86/include/asm/intel-family.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> index 9f15384c504a..087de5d3b93a 100644
> --- a/arch/x86/include/asm/intel-family.h
> +++ b/arch/x86/include/asm/intel-family.h
> @@ -53,6 +53,7 @@
> #define INTEL_FAM6_CANNONLAKE_MOBILE 0x66
>
> #define INTEL_FAM6_ICELAKE_MOBILE 0x7E
> +#define INTEL_FAM6_ICELAKE_NNPI 0x9D
>
> /* "Small Core" Processors (Atom) */
>
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko

2019-06-04 19:25:57

by Bhardwaj, Rajneesh

Subject: Re: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family

Hi Andy

On 04-Jun-19 9:39 PM, Andy Shevchenko wrote:
> On Thu, May 30, 2019 at 06:08:27PM +0530, Rajneesh Bhardwaj wrote:
>> Add the CPUID model number of Icelake Neural Network Processor for Deep
> I believe we spell "Ice Lake".

I referred to https://patchwork.kernel.org/patch/10812551/ ,
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e394376ee89233508fa21d006546357f8efee31
and many others where it mentioned Icelake. I am fine to change it the
way you are suggesting, please confirm if its still needed and i will
send a v2.

Thank you.

>
>> Learning Inference (ICL-NNPI) to the Intel family list. Icelake NNPI uses
> Ditto.
>
>> model number 0x9D and this will be documented in a future version of Intel
>> Software Development Manual.
>>
>> Cc: Borislav Petkov <[email protected]>
>> Cc: Dave Hansen <[email protected]>
>> Cc: Andy Shevchenko <[email protected]>
>> Cc: "H. Peter Anvin" <[email protected]>
>> Cc: Ingo Molnar <[email protected]>
>> Cc: Kan Liang <[email protected]>
>> Cc: Peter Zijlstra <[email protected]>
>> Cc: [email protected]
>> Cc: Qiuxu Zhuo <[email protected]>
>> Cc: Srinivas Pandruvada <[email protected]>
>> Cc: Len Brown <[email protected]>
>> Cc: Thomas Gleixner <[email protected]>
>> Cc: x86-ml <[email protected]>
>> Cc: Linux PM <[email protected]>
>> Signed-off-by: Rajneesh Bhardwaj <[email protected]>
>> ---
>> arch/x86/include/asm/intel-family.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
>> index 9f15384c504a..087de5d3b93a 100644
>> --- a/arch/x86/include/asm/intel-family.h
>> +++ b/arch/x86/include/asm/intel-family.h
>> @@ -53,6 +53,7 @@
>> #define INTEL_FAM6_CANNONLAKE_MOBILE 0x66
>>
>> #define INTEL_FAM6_ICELAKE_MOBILE 0x7E
>> +#define INTEL_FAM6_ICELAKE_NNPI 0x9D
>>
>> /* "Small Core" Processors (Atom) */
>>
>> --
>> 2.17.1
>>

2019-06-05 10:34:18

by Andy Shevchenko

Subject: Re: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family

On Wed, Jun 05, 2019 at 12:54:12AM +0530, Bhardwaj, Rajneesh wrote:
> Hi Andy
>
> On 04-Jun-19 9:39 PM, Andy Shevchenko wrote:
> > On Thu, May 30, 2019 at 06:08:27PM +0530, Rajneesh Bhardwaj wrote:
> > > Add the CPUID model number of Icelake Neural Network Processor for Deep
> > I believe we spell "Ice Lake".
>
> I referred to https://patchwork.kernel.org/patch/10812551/ , https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e394376ee89233508fa21d006546357f8efee31
> and many others where it mentioned Icelake. I am fine to change it the way
> you are suggesting, please confirm if its still needed and i will send a v2.

I think the references have a mistake as well.

--
With Best Regards,
Andy Shevchenko