2019-05-30 20:59:39

by Nishka Dasgupta

Subject: [PATCH] staging: rtl8712: Replace function r8712_free_network_queue

Remove function r8712_free_network_queue as it does nothing except call
_free_network_queue.
Rename _free_network_queue to r8712_free_network_queue (and change its
type to static) for continued use of the original functionality.

Signed-off-by: Nishka Dasgupta <[email protected]>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 57d8e7dceef7..f6ba3e865a30 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -151,7 +151,7 @@ static struct wlan_network *_r8712_find_network(struct __queue *scanned_queue,
return pnetwork;
}

-static void _free_network_queue(struct _adapter *padapter)
+void r8712_free_network_queue(struct _adapter *padapter)
{
unsigned long irqL;
struct list_head *phead, *plist;
@@ -215,11 +215,6 @@ static struct wlan_network *alloc_network(struct mlme_priv *pmlmepriv)
return _r8712_alloc_network(pmlmepriv);
}

-void r8712_free_network_queue(struct _adapter *dev)
-{
- _free_network_queue(dev);
-}
-
/*
* return the wlan_network with the matching addr
* Shall be called under atomic context...
--
2.19.1

2019-06-03 12:28:14

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8712: Replace function r8712_free_network_queue

On Fri, May 31, 2019 at 02:27:55AM +0530, Nishka Dasgupta wrote:
> Remove function r8712_free_network_queue as it does nothing except call
> _free_network_queue.
> Rename _free_network_queue to r8712_free_network_queue (and change its
> type to static) for continued use of the original functionality.

You did not change the type to static:

> -static void _free_network_queue(struct _adapter *padapter)
> +void r8712_free_network_queue(struct _adapter *padapter)

:(