2019-06-03 10:50:18

by Rasmus Villemoes

Subject: [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static

mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
static.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
drivers/net/dsa/mv88e6xxx/global1.c | 2 +-
drivers/net/dsa/mv88e6xxx/global1.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/global1.c b/drivers/net/dsa/mv88e6xxx/global1.c
index b5ceff2946fe..770c03406033 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.c
+++ b/drivers/net/dsa/mv88e6xxx/global1.c
@@ -465,7 +465,7 @@ int mv88e6xxx_g1_set_device_number(struct mv88e6xxx_chip *chip, int index)

/* Offset 0x1d: Statistics Operation 2 */

-int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip)
+static int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip)
{
return mv88e6xxx_g1_wait(chip, MV88E6XXX_G1_STATS_OP,
MV88E6XXX_G1_STATS_OP_BUSY);
diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
index 2f195a0bd891..bb92a130cbef 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.h
+++ b/drivers/net/dsa/mv88e6xxx/global1.h
@@ -263,7 +263,6 @@ int mv88e6352_g1_reset(struct mv88e6xxx_chip *chip);
int mv88e6185_g1_ppu_enable(struct mv88e6xxx_chip *chip);
int mv88e6185_g1_ppu_disable(struct mv88e6xxx_chip *chip);

-int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip);
int mv88e6xxx_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
int mv88e6320_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
int mv88e6390_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
--
2.20.1

2019-06-03 14:10:09

by Vivien Didelot

Subject: Re: [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static

On Mon, 3 Jun 2019 08:04:09 +0000, Rasmus Villemoes <[email protected]> wrote:
> mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
> static.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Reviewed-by: Vivien Didelot <[email protected]>

2019-06-03 17:54:02

by David Miller

Subject: Re: [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static

From: Rasmus Villemoes <[email protected]>
Date: Mon, 3 Jun 2019 08:04:09 +0000

> mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
> static.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Applied to net-next.